test(sleep): strengthen verifier-discipline test with score/gate_action assertions#110
Open
harshitnagar22 wants to merge 2 commits into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #94. Strengthens
TestVerifierDisciplineintests/test_sleep_engine.pywith three concrete improvements:Changes
test_gate_rejects_reward_hacking_edit(enhanced) — now asserts concretebaseline_score=1.0andcandidate_score=0.0so the rejection is verifiably score-driven, plus assertsgate_action="reject"to bring the vendoredevaluate_gate()under test.test_gate_accepts_genuine_improvement(new) — paired accept case usingMockImprovingBackend: an edit that genuinely improves the held-out slice. Assertsaccepted=True,baseline_score=0.0,candidate_score=1.0,gate_action="accept_new_best".test_gate_rejects_subtle_reward_hack(new) — a more realistic reward-hack scenario usingMockSubtleHackBackend: train improves from 0.0→1.0 (looks good!) but held-out degrades from 1.0→0.5. Gate correctly rejects, proving it catches non-obvious regressions, not just all-or-nothing collapses.Why
Verifier discipline (only adopt edits that improve a held-out slice) is the core safety property of the sleep loop. Pinning scores + asserting
gate_actionturns the test from a smoke test into a real regression guard against gate regressions. The paired accept/reject cases ensure the gate works in both directions.