Skip to content

Add a "From" email address to email Report task - #48

Open
fahadash (fahadash) wants to merge 6 commits into
microsoft:masterfrom
fahadash:master
Open

Add a "From" email address to email Report task#48
fahadash (fahadash) wants to merge 6 commits into
microsoft:masterfrom
fahadash:master

Conversation

@fahadash

Copy link
Copy Markdown

Currently there is no way to specify in the configuration what do you want email's from address to be. It assumes that the SMTP's username is the from address. But for SMTP service connections where username is not an actual email adddress (does not have @ or domain), this tasks fail at runtime.

This PR will Fix #42 by giving user an optional From email configuration field. If skipped, it will defer back to using SMTP's username. This has minimal impact.

@ghost

Deleted user (ghost) commented Oct 30, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The field was added the same way as other exiting fields.

@TripleEmcoder

Copy link
Copy Markdown

Well, I tried, but it seems we need someone with true approving powers :)

@fahadash

Copy link
Copy Markdown
Author

Marcin Mikołajczak (@TripleEmcoder) I appreciate that. Until Microsoft decides to wake up and do something about it, I found a workaround. A powershell script that makes use of System.Net.Smtp to connect to your SMTP server and sends that email.

@TripleEmcoder

Marcin Mikołajczak (TripleEmcoder) commented Aug 27, 2021

Copy link
Copy Markdown

Where do you get the content from? Does the plugin write it somewhere accessible? Could you share the PowerShell script for others to use?

Hopefully someone will get a few notifications now with our activity and find the time to merge the changes.

@fahadash

fahadash (fahadash) commented Sep 1, 2021

Copy link
Copy Markdown
Author

Where do you get the content from? Does the plugin write it somewhere accessible? Could you share the PowerShell script for others to use?

Hopefully someone will get a few notifications now with our activity and find the time to merge the changes.

Marcin Mikołajczak (@TripleEmcoder) Sorry for delayed response here is the script that I wrote

$EmailFrom = no-reply@yourcompany.com
$EmailTo = recipients@yourcompany.com
$Subject = App Deployment Started
$Body = We are taking down the app to deploy the build <a href=`"https://dev.azure.com/Company/projectl/_traceability/runview/changes?currentRunId=$(Build.BuildId)`">$(Build.BuildNumber)</a>, Release $(Release.ReleaseId). 
$SMTPServer = smtp.server.com
$SMTPClient = New-Object Net.Mail.SmtpClient($SmtpServer, 587)
$SMTPClient.EnableSsl = $true
$SMTPClient.Credentials = New-Object System.Net.NetworkCredential("username", "password");
$mail = New-Object System.Net.Mail.Mailmessage $EmailFrom, $EmailTo, $Subject, $Body
$mail.IsBodyHtml = $true

$SMTPClient.Send($mail)

@ksista-ahc

ksista-ahc (ksista-ahc) commented Oct 1, 2021

Copy link
Copy Markdown

Any idea when this PR can be merged. There is a definite need to fix this extension fahadash (@fahadash) Microsoft Open Source (@microsoftopensource)

ddeglin
ddeglin previously approved these changes Oct 7, 2021
@fahadash fahadash (fahadash) changed the title Add a "From" email address to email Report task Bump: Add a "From" email address to email Report task Oct 20, 2021
@fahadash fahadash (fahadash) changed the title Bump: Add a "From" email address to email Report task Add a "From" email address to email Report task Oct 20, 2021
@xiuzhen1103

Copy link
Copy Markdown

Any update on this pull request approval?

@ksista-ahc

Copy link
Copy Markdown

Marcin Mikołajczak (@TripleEmcoder) ddeglin rBuilder-cafeto (@devops-cafeto) Could anyone of you approve the PR and merge it.

@fahadash

Copy link
Copy Markdown
Author

Sai Krishna V (@saikrishnav) Could you merge this PR?

@ksista-ahc

Copy link
Copy Markdown

Sai Krishna V (@saikrishnav) Could you please approve this PR and unblock us... This plugin is a definite need for us

@fahadash

Copy link
Copy Markdown
Author

LeahSchwartz Could you help us out? We need these changes merged ASAP to unblock us.

Peadge
Peadge (Peadge) previously approved these changes Dec 3, 2021
@Peadge

Copy link
Copy Markdown

LeahSchwartz or anyone else PLEASE can you approve the changes so this can be merged in, it's the ONLY extension that can email test results out from the Release pipeline.

@fahadash

Copy link
Copy Markdown
Author

I have sent an email to opensource@microsoft.com asking for help. Hoping for the best.

@Naweap

Copy link
Copy Markdown

Any news on that PR ?

@fahadash

Copy link
Copy Markdown
Author

I never received a response from Microsoft OpenSource to my email. I am going to try tweeting to their twitter handle, you guys try it too.

@Naweap

Copy link
Copy Markdown

I never received a response from Microsoft OpenSource to my email. I am going to try tweeting to their twitter handle, you guys try it too.

Alright, thanks for your answer, it will try it too. However, I don't want to be pessimistic, but it has been almost one year since they didn't release any new version of this extension. By the time this PR is merged and we see this improvement in prod, I think it's gonna take time.

Comment thread Tasks/emailReportTask/config/ConfigurationProvider.ts Outdated
@dan-hoeger

Copy link
Copy Markdown

Is there any update on this? we require the ability to specify the "From" address when using an AWS SMTP service.

@asultan80

Copy link
Copy Markdown

fahadash (@fahadash) Can you remove the review request from ddeglin ?

Comment thread Tasks/emailReportTask/config/ConfigurationProvider.ts Outdated
@asultan80

Copy link
Copy Markdown

Sai Krishna V (@saikrishnav) Please, take a look and help to resolve this one.
Thank you!

@fahadash

Copy link
Copy Markdown
Author

I think we may have to call Microsoft PSS to get their attention into this.

@fahadash

Copy link
Copy Markdown
Author

ddeglin This PR is waiting on you again, could you look into this please?

@fahadash

Copy link
Copy Markdown
Author

Sai Krishna V (@saikrishnav) Could you merge this PR please?

@ZaafirDar

Copy link
Copy Markdown

fahadash (@fahadash) Can we please get this PR merged, still running into this problem.

@fahadash

Copy link
Copy Markdown
Author

Looks like we have lost ddeglin , I am going to convert this to draft, that is probably going to remove the existing approvals.

@fahadash
fahadash (fahadash) marked this pull request as draft September 19, 2023 15:56
@fahadash
fahadash (fahadash) marked this pull request as ready for review September 19, 2023 18:07
@fahadash

Copy link
Copy Markdown
Author

It turns out that we have to wait for a Build to occur before this PR can be merged.

@ZaafirDar

Copy link
Copy Markdown

fahadash (@fahadash) Any Idea how is build triggered? Should we expect any response on this?

@fahadash

Copy link
Copy Markdown
Author

Sai Krishna V (@saikrishnav) Could you get the build 10.x check taken care of?

@ZaafirDar

Copy link
Copy Markdown

Sai Krishna V (@saikrishnav) can you help us with build (10.x) Check?

@andrew-aladev

Andrew Aladjev (andrew-aladev) commented Nov 10, 2025

Copy link
Copy Markdown

Why this obvious pull request is still opened from 2024 year? Is this repository dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E-Mail "From" field is not available