Open
Conversation
Detects HMACMD5, HMACSHA1, and HMACRIPEMD160 usage via New-Object, static Create(), and ::new() patterns. Covers: Cryptography.10020 (CWE-327, CWE-328) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MathiasVP
reviewed
Apr 15, 2026
Collaborator
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
Two small comments, but otherwise this LGTM!
Comment on lines
+183
to
+187
| ( | ||
| objectName = "system.security.cryptography." + algName or | ||
| objectName = algName | ||
| ) and | ||
| isHmacAlgorithm(algName) |
Collaborator
There was a problem hiding this comment.
In the class further below (i.e., XXX) we do this:
objectName = ["", "system.security.cryptography."] + algName and
isHmacAlgorithm(algName)could we not do a similarly pretty thing here?
| import semmle.code.powershell.security.cryptography.Concepts | ||
|
|
||
| from HmacAlgorithm hmacAlg | ||
| where not hmacAlg.getHmacName() = ["hmacsha256", "hmacsha384", "hmacsha512"] |
Collaborator
There was a problem hiding this comment.
This will also raise an alert if no name can be found (i.e., getHmacName returns no results). Two questions:
- Can that ever happen?
- If so, is that what we want?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.