Skip to content

PS: Add GUID as simple sanitizers #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 2 commits into from
Apr 16, 2026
+12 −3
Merged

PS: Add GUID as simple sanitizers #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6da1c01
PS: Add false positive with GUID.
MathiasVP Apr 15, 2026
6465ecd
PS: Add GUIDs as a simple sanitizer, and accept test changes.
MathiasVP Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions powershell/ql/lib/semmle/code/powershell/security/Sanitizers.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ private import semmle.code.powershell.dataflow.DataFlow
/**
* A dataflow node that is guarenteed to have a "simple" type.
*
* Simple types include integers, floats, characters, booleans, and `datetime`.
* Simple types include integers, floats, characters, booleans, `datetime`, and `guid`.
*/
class SimpleTypeSanitizer extends DataFlow::Node {
SimpleTypeSanitizer() {
this.asParameter().getStaticType() =
["int32", "int64", "single", "double", "decimal", "char", "boolean", "datetime"]
["int32", "int64", "single", "double", "decimal", "char", "boolean", "datetime", "guid"]
}
}
11 changes: 10 additions & 1 deletion powershell/ql/test/query-tests/security/cwe-089/test.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,13 @@ $QueryConn3 = @{

Invoke-Sqlcmd @QueryConn3 # GOOD

&sqlcmd -e -S $userinput -U "Login" -P "MyPassword" -d "MyDBName" -i "input_file.sql" # GOOD
&sqlcmd -e -S $userinput -U "Login" -P "MyPassword" -d "MyDBName" -i "input_file.sql" # GOOD

function WithGuid {
PARAM([Parameter(Mandatory = $true)] [guid] $r)

$query = "SELECT * FROM MyTable WHERE MyColumn = '$r'"
Invoke-Sqlcmd -ServerInstance "MyServer" -Database "MyDatabase" -q $query # GOOD
}

WithGuid $userinput
Loading