[dev-v5][Menu] Update FluentMenu not opening#4858
Merged
Merged
Conversation
dvoituron
approved these changes
May 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FluentMenu JavaScript/TypeScript initialization to align with the Fluent UI web-components behavior change (per fluentui/fluentui#36018), ensuring the menu trigger slot registration is performed in the way the updated web component expects.
Changes:
- Replaced manual mutation of
menu.slottedTriggerswith a call toslottedTriggersChanged(...)to register the trigger. - Removed the call to
menu.setComponent()as part of initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
microsoft/fluentui#36018 changed the behaviour how we need to register the trigger slot in
FluentMenu. This PR addresses this change.✅ Checklist
General
Component-specific
⏭ Next Steps