Skip to content

[dev-v5][Menu] Update FluentMenu not opening#4858

Merged
dvoituron merged 1 commit into
microsoft:dev-v5from
MarvinKlein1508:fix-menu-trigger
May 13, 2026
Merged

[dev-v5][Menu] Update FluentMenu not opening#4858
dvoituron merged 1 commit into
microsoft:dev-v5from
MarvinKlein1508:fix-menu-trigger

Conversation

@MarvinKlein1508
Copy link
Copy Markdown
Collaborator

Pull Request

📖 Description

microsoft/fluentui#36018 changed the behaviour how we need to register the trigger slot in FluentMenu. This PR addresses this change.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

Copilot AI review requested due to automatic review settings May 13, 2026 08:02
@dvoituron dvoituron enabled auto-merge (squash) May 13, 2026 08:04
@dvoituron dvoituron merged commit ea3fcfd into microsoft:dev-v5 May 13, 2026
5 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the FluentMenu JavaScript/TypeScript initialization to align with the Fluent UI web-components behavior change (per fluentui/fluentui#36018), ensuring the menu trigger slot registration is performed in the way the updated web component expects.

Changes:

  • Replaced manual mutation of menu.slottedTriggers with a call to slottedTriggersChanged(...) to register the trigger.
  • Removed the call to menu.setComponent() as part of initialization.

@MarvinKlein1508 MarvinKlein1508 deleted the fix-menu-trigger branch May 13, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants