[SDK V2] Remove const from BytesView.data in JS binding - #949
Merged
Conversation
…ues, and we were const_casting to use the value.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unnecessary const-casts from JS byte-buffer handling and correctly positions BytesView outside the parser documentation.
Changes:
- Makes
BytesView.datamutable. - Passes native buffer pointers directly to owning item factories.
- Moves
BytesViewbeforeParseBytesValuedocumentation.
baijumeswani
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's populated with non-const values, and we were const_cast'ing to use the value.
Also move the definition up as it was in the middle of the ParseBytesValue function's documentation