fix: preserve TypeScript builders for trailing-slash paths by Shubham-Padkonde · Pull Request #8251 · microsoft/kiota

Shubham Padkonde (Shubham-Padkonde) · 2026-09-21T12:32:10Z

Request builders for /token and /token/ occupy the same namespace but were placed in separate CodeFiles. Both files normalize to index.ts, so writing one overwrote the other, losing request metadata and inline model serializers/factories. Group the request-builder files before import cleanup so each output path contains all its declarations.

When several builders share a file, select the URI template belonging to the metadata's original request-builder class rather than the first template in that file. Update hand-built writer test fixtures to supply the same original-class association as generated constants.

Validation:

New builder/refiner/writer regression fails before the fix (two files targeting one output path) and passes after it. Covers both request builders, inline body/response interfaces, and each metadata constant's own URI template.
All 189 TypeScript-focused tests pass, including existing literal-escaping tests.
.NET 10 CLI build passes with four environment-related SourceLink warnings.
Regenerated the full Pipedrive schema: TypeScript 5.8.2 compilation passes. A runtime export check fails on the original output and passes with the fix; the actual Kiota proxy builds /oauth/token/ with the expected form-encoded grant_type and refresh_token.
A minimal generated client preserves distinct /token and /token/ URLs and its JSON request body.
Scoped formatting verification passes.
No external HTTP requests were sent by the runtime checks.

Prepared with Codex assistance.

Vincent Biret (baywet) · 2026-09-21T13:06:21Z

Shubham Padkonde (@Shubham-Padkonde) your behaviour is disruptive, opening about 30 PRs on the repos in a couple of hours time, most likely code that was AI generated and not tested/reviewed, will only clog our review pipeline. Please stop opening additional pull requests and work on the comments added to existing ones. We have turned on pull requests limits on this repository, and will proceed to blocking you at the organization level if additional pull requests are opened on other repositories before the already opened ones are reviewed and closed/or merged.

Copilot

Copilot review overview

🟢 Approval recommended

The changes align with TypeScript path normalization behavior, add targeted regression coverage, and the updated writer logic correctly preserves per-builder URI template associations without introducing new unsafe literal emissions.

Review effort: Lite
Findings: None

What changed in this PR

This PR fixes a TypeScript codegen edge case where request builders for paths that differ only by a trailing slash (e.g., /token and /token/) end up targeting the same emitted file (index.ts), causing one builder’s declarations (including inline model serializers/factories and request metadata) to be overwritten.

Changes:

Group TypeScript request-builder CodeFiles per namespace before import cleanup so all declarations that normalize to the same output file are written together.
Ensure each requests-metadata constant references the URI-template constant associated with its own original request-builder class (via OriginalCodeElement), not the first template in the file.
Add/adjust tests to cover the trailing-slash collision scenario and validate correct URI-template selection per metadata constant.

File	Description
`src/Kiota.Builder/Refiners/TypeScriptRefiner.cs`	Adds request-builder file grouping to prevent `index.ts` overwrite when multiple builders normalize to the same output path.
`src/Kiota.Builder/Writers/TypeScript/CodeConstantWriter.cs`	Fixes URI-template association for request metadata by matching on `OriginalCodeElement`.
`tests/Kiota.Builder.Tests/Writers/TypeScript/CodeConstantWriterTests.cs`	Updates fixtures to set `OriginalCodeElement` on URI-template constants to reflect production behavior.
`tests/Kiota.Builder.Tests/KiotaBuilderTests.TypeScriptTrailingSlash.cs`	Adds regression test ensuring both trailing-slash builders and their inline types survive, and metadata uses the correct template constant.
`CHANGELOG.md`	Documents the TypeScript trailing-slash preservation fix.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Vincent Biret (baywet) · 2026-09-23T11:20:27Z

Shubham Padkonde (@Shubham-Padkonde) this PR is conflicting, would you mind handling the conflicts when you have a minute please?

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot review overview

🟡 Changes recommended

A critical merged-import collision issue and a moderate regression coverage gap remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Alias imports colliding with declarations in merged index.ts · New

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Shubham Padkonde (Shubham-Padkonde) · 2026-09-23T13:51:45Z

Fixed the merged-file import/declaration collision in 2de1c6a. After grouping request-builder files, the refiner now aliases child imports against the complete set of declarations in the merged file.

Added an OpenAPI regression with /token and /token/, where the latter returns a model named TokenRequestBuilder. The regression fails before the fix because the model import has no alias and passes afterward. All 176 TypeScript writer/refiner tests and 8 selected generation cases pass; the .NET 10 build has zero warnings/errors, and scoped whitespace formatting plus git diff --check pass. This follow-up was not validated by recompiling the full Pipedrive client.

Prepared and tested with OpenAI Codex assistance.

Copilot

Copilot review overview

🟢 Approval recommended

The fix and regression coverage address the trailing-slash collision and preserve builder-specific metadata.

Review effort: Lite
Findings: None

Resolved since last review (1)

Alias imports colliding with declarations in merged index.ts

github-actions · 2026-09-23T17:01:38Z

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

github-actions · 2026-09-23T17:17:23Z

Conflicts have been resolved. A maintainer will take a look shortly.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-09-23T18:23:12Z

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-09-24T01:03:30Z

Conflicts have been resolved. A maintainer will take a look shortly.

github-actions · 2026-09-25T00:18:15Z

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-09-25T01:34:24Z

Conflicts have been resolved. A maintainer will take a look shortly.

github-actions · 2026-09-25T01:34:25Z

Conflicts have been resolved. A maintainer will take a look shortly.

github-actions · 2026-09-25T21:24:16Z

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-09-25T21:45:19Z

Conflicts have been resolved. A maintainer will take a look shortly.

fix: preserve TypeScript builders for trailing-slash paths

cf804c5

Shubham Padkonde (Shubham-Padkonde) requested a review from a team as a code owner September 21, 2026 12:32

Vincent Biret (baywet) requested a lite review from Copilot September 21, 2026 13:02

Copilot started reviewing on behalf of Vincent Biret (baywet) September 21, 2026 13:02 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Merge main to resolve PR 8251 changelog conflict

d25c2cf

Copilot AI review requested due to automatic review settings September 21, 2026 16:35

Copilot AI reviewed Sep 21, 2026

Merge main to resolve PR 8251 changelog conflict

cc0218e

Copilot AI review requested due to automatic review settings September 22, 2026 09:25

Copilot AI reviewed Sep 22, 2026

Merge main to resolve PR 8251 changelog conflict

36a5e30

Copilot AI review requested due to automatic review settings September 22, 2026 14:43

Copilot AI reviewed Sep 22, 2026

Merge main to resolve PR 8251 changelog conflict

c94368e

Copilot AI review requested due to automatic review settings September 23, 2026 12:09

Copilot AI reviewed Sep 23, 2026

Vincent Biret (baywet) requested a lite review from Copilot September 23, 2026 13:33

Copilot started reviewing on behalf of Vincent Biret (baywet) September 23, 2026 13:35 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread src/Kiota.Builder/Refiners/TypeScriptRefiner.cs

fix: alias imports against merged request builder declarations

2de1c6a

Copilot AI review requested due to automatic review settings September 23, 2026 13:51

Copilot AI reviewed Sep 23, 2026

Vincent Biret (baywet) requested a lite review from Copilot September 23, 2026 14:06

Copilot started reviewing on behalf of Vincent Biret (baywet) September 23, 2026 14:08 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Merge main to resolve PR 8251 changelog conflict

abbaa7a

github-actions Bot added the conflicting label Sep 23, 2026

Merge main to resolve PR 8251 changelog conflict

af8a04b

Copilot AI review requested due to automatic review settings September 23, 2026 17:17

github-actions Bot removed the conflicting label Sep 23, 2026

Copilot AI reviewed Sep 23, 2026

github-actions Bot added the conflicting label Sep 23, 2026

Merge main to resolve PR 8251 changelog conflict

057b63e

Copilot AI review requested due to automatic review settings September 24, 2026 01:03

Copilot AI reviewed Sep 24, 2026

github-actions Bot removed the conflicting label Sep 24, 2026

github-actions Bot added the conflicting label Sep 25, 2026

Merge main to resolve PR 8251 changelog conflict

d34cb0b

Copilot AI review requested due to automatic review settings September 25, 2026 01:34

Copilot AI reviewed Sep 25, 2026

github-actions Bot removed conflicting labels Sep 25, 2026

github-actions Bot added the conflicting label Sep 25, 2026

Merge main to resolve PR 8251 changelog conflict

fdf538b

Copilot AI review requested due to automatic review settings September 25, 2026 21:45

Copilot AI reviewed Sep 25, 2026

github-actions Bot removed the conflicting label Sep 25, 2026

Conversation

Shubham Padkonde (Shubham-Padkonde) commented Sep 21, 2026

Uh oh!

Vincent Biret (baywet) commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Vincent Biret (baywet) commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Shubham Padkonde (Shubham-Padkonde) commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants