Preserve guest floating-point and extended CPU state on Windows - #1340
Merged
Conversation
Weiteng Chen (CvvT)
marked this pull request as ready for review
September 10, 2026 00:30
Member
|
Sangho Lee (@sangho2) can you help review this PR? Thanks! |
Contributor
|
Do we need to worry about the below? perhaps out of this PR's scope (AArch64 Linux variant somehow handles it). |
Sangho Lee (sangho2)
approved these changes
Sep 10, 2026
Sangho Lee (sangho2)
left a comment
Sangho Lee (sangho2)
left a comment
Contributor
There was a problem hiding this comment.
Overall, looks good to me. We might want to use XSAVEC or XAVEOPT later, but better to have a correct implementation first.
Contributor
Author
Yes, we should, but probably after I also fix Linux userland platform. |
Weiteng Chen (CvvT)
force-pushed
the
weiteng/windows_save_fp_state
branch
from
September 11, 2026 19:03
d90f306 to
597c787
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve guest floating-point and SIMD state across syscalls, exceptions, and host interrupts, while ensuring host Rust code runs with Windows ABI floating-point controls.
rip, save guest state with XSAVE and restore it with XRSTOR on the fast resume path.rip, save guest state with XSAVE but restore it with NtContinue.