Fix Windows process waiting and avoid slab allocator shutdown deadlock - #1348
Draft
Weiteng Chen (CvvT) wants to merge 5 commits into
Draft
Fix Windows process waiting and avoid slab allocator shutdown deadlock#1348Weiteng Chen (CvvT) wants to merge 5 commits into
Weiteng Chen (CvvT) wants to merge 5 commits into
Conversation
Follow the Linux shim's thread-count wait/wake pattern, close thread creation on the last detach, and synchronize the process exit status under the thread registry lock. This waits for guest completion only. Host-thread and broker-worker shutdown remain separate work: shim-only run_multithreaded_pe stress reproduced the ExitProcess allocator deadlock on repetition six.
Remove the platform's global SafeZoneAllocator declaration so Rust heap allocations use the default allocator. Leave guest page management and the MemoryProvider implementation unchanged. Avoid the slab spinlock involved in the observed ExitProcess TLS-cleanup deadlock. The rebuilt run_multithreaded_pe test and 50 sequential no-retry stress repetitions passed. Detached-worker shutdown remains a separate lifecycle concern.
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.