Drop mu_pi and mu_rust_helpers crate dependencies (and fix build due to incoming r-efi v7) [Rebase & FF]#907
Merged
makubacki merged 4 commits intoJun 24, 2026
Conversation
mu_rust_helpers re-exports mu_uefi_guid, which updated to r-efi v7. Its `guid::ZERO` and `guid::CALLER_ID` constants are compiled against r-efi v7, while patina (and the rest of the tree) remain on r-efi v6, producing mismatched-type errors when those constants are used in v6 contexts. This makes the move to the patina crate's GUID constants. The patina version used here is still on r-efi v6, so its `patina::guids::ZERO` and `patina::guids::CALLER_ID` constants are compiled against r-efi v6. This is also a step toward removing the mu_rust_helpers dependency from this crate. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Replaces the mu_pi status code types and error-code constants with the equivalent definitions from the patina crate (`patina::pi::status_code` and `patina::pi::protocols::status_code`). This removes the mu_pi dependency from the crate and the workspace. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Makes the remaining changes needed to replace mu_rust_helpers with the patina crate. This is part of the effort to remove mu_rust_helpers as it is being deprecated. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Makes the remaining changes needed in UefiHidDxeV2 to use patina::function instead of mu_rust_helpers::function so the crate dependency can be removed from the workspace. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_plus/actions/runs/28109413419 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
mu-automation
Bot
added
the
impact:non-functional
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #907 +/- ##
=================================================
Coverage ? 10.21%
=================================================
Files ? 150
Lines ? 24568
Branches ? 2346
=================================================
Hits ? 2509
Misses ? 22023
Partials ? 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
os-d
approved these changes
Jun 24, 2026
cfernald
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A series of commits with two goals:
mu_rust_helpersmoved to r-efi v7 in eefef09. The minor version was updated which caused many crates depending onmu_rust_helpersto pick up the change automatically per semantic versioning while there other dependencies stayed on r-efi v6. This could lead to type mismatches (and did in this repo). So, this prevents that.mu_rust_helpersandmu_pi(as described in Deprecate mu_rust_helpers #906) by removing their usage in this repo.MuTelemetryHelperLib: Fix r-efi v7 GUID constant conflict
mu_rust_helpers re-exports mu_uefi_guid, which updated to r-efi v7.
Its
guid::ZEROandguid::CALLER_IDconstants are compiled againstr-efi v7, while patina (and the rest of the tree) remain on r-efi v6,
producing mismatched-type errors when those constants are used in v6
contexts.
This makes the move to the patina crate's GUID constants. The patina
version used here is still on r-efi v6, so its
patina::guids::ZEROand
patina::guids::CALLER_IDconstants are compiled against r-efiv6.
This is also a step toward removing the mu_rust_helpers dependency
from this crate.
MuTelemetryHelperLib: Use patina instead of mu_pi
Replaces the mu_pi status code types and error-code constants with the
equivalent definitions from the patina crate (
patina::pi::status_codeand
patina::pi::protocols::status_code).This removes the mu_pi dependency from the crate and the workspace.
MsWheaPkg: Remove mu_rust_helpers dependency
Makes the remaining changes needed to replace mu_rust_helpers with
the patina crate. This is part of the effort to remove mu_rust_helpers
as it is being deprecated.
Remove mu_rust_helpers as a workspace dependency
Makes the remaining changes needed in UefiHidDxeV2 to use
patina::function instead of mu_rust_helpers::function so the
crate dependency can be removed from the workspace.
How This Was Tested
Integration Instructions
mu_rust_helpersandmu_pifunctionality with equivalent functionality from thepatinacrate. Thepatinacrate was already a dependency.