Patina 22.1.0 integration (r-efi 7) [Rebase & FF]#908
Merged
makubacki merged 2 commits intoJun 25, 2026
Conversation
Library crates are currently being listed in the `members` section, so the line about binary crates is removed. RustAdvancedLoggerDxe is currently being built as a dependency, but this commit adds it as a member for consistency with other crates. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
patina 22.1.0 moved its r-efi dependency up to version 7, but the workspace was still pinned to ^6. Cargo then pulled in both r-efi 6 and 7 at the same time, and since types from different major versions don't unify, that broke `cargo make check` and `cargo make test`. This moves the workspace to r-efi 7. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_plus/actions/runs/28136453247 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #908 +/- ##
=================================================
Coverage ? 10.21%
=================================================
Files ? 150
Lines ? 24568
Branches ? 2346
=================================================
Hits ? 2509
Misses ? 22023
Partials ? 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mu-automation
Bot
added
the
impact:breaking-change
Member
Author
|
To be conservative, I marked this as a breaking change to bring awareness to the r-efi version update. |
apop5
approved these changes
Jun 25, 2026
os-d
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two commits to integrate the latest patina v22.1.0 (and fix the build).
Cargo.toml: Add AdvLoggerPkg/Crates/RustAdvancedLoggerDxe as a member
Library crates are currently being listed in the
memberssection, sothe line about binary crates is removed.
RustAdvancedLoggerDxe is currently being built as a dependency, but
this commit adds it as a member for consistency with other crates.
Bump r-efi to 7 to match patina's update
patina 22.1.0 moved its r-efi dependency up to version 7, but the
workspace was still pinned to ^6.
Cargo then pulled in both r-efi 6 and 7 at the same time, and since
types from different major versions don't unify, that broke
cargo make checkandcargo make test.This moves the workspace to r-efi 7.
How This Was Tested
Integration Instructions