AdvLoggerPkg: PeilessArm: Check if Buffer Is Already Valid#911
Merged
Conversation
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_plus/actions/runs/28245837160 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #911 +/- ##
================================================
Coverage ? 3.02%
================================================
Files ? 37
Lines ? 4327
Branches ? 73
================================================
Hits ? 131
Misses ? 4190
Partials ? 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apop5
approved these changes
Jun 26, 2026
makubacki
approved these changes
Jun 26, 2026
PeilessArm currently assumes it is setting up the adv logger buffer. However, an earlier phase may have initialized the buffer, such as StMM running before SEC is started. This adds a check to see if the buffer is already valid and just inherits it if so. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PeilessArm currently assumes it is setting up the adv logger buffer. However, an earlier phase may have initialized the buffer, such as StMM running before SEC is started.
This adds a check to see if the buffer is already valid and just inherits it if so.
How This Was Tested
Tested on a platform where StMM initializes the log buffer and runs before SEC.
Integration Instructions
N/A.