[REBASE & FF] AdvLoggerPkg: PeiCore Instance: Update Override Tag And Apply SecDebugAgent Fix#912
Merged
Merged
Conversation
Update the override tag in PeiMain.h as it has been updated in basecore v2025110002.0.8. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
mu-automation
Bot
added
impact:breaking-change
Contributor
⏩ QEMU Validation SkippedThe PR was merged before validation completed. This comment was automatically generated by the Mu QEMU PR Validation workflow. |
apop5
approved these changes
Jun 26, 2026
When the local PeiMain.h was brought in, SecDebugAgent was missed. Use the local as a temporary workaround. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
kuqin12
approved these changes
Jun 26, 2026
apop5
approved these changes
Jun 26, 2026
os-d
changed the title
makubacki
approved these changes
Jun 26, 2026
makubacki
left a comment
makubacki
left a comment
Member
There was a problem hiding this comment.
Approving to amend the hack with GitHub issue tracking long term solution.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #912 +/- ##
================================================
Coverage ? 3.02%
================================================
Files ? 37
Lines ? 4327
Branches ? 73
================================================
Hits ? 131
Misses ? 4190
Partials ? 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the override tag in PeiMain.h as it has been updated in basecore v2025110002.0.8.
Also, SecDebugAgent was missed when using the local header, update it.
How This Was Tested
N/A.
Integration Instructions
This is marked as a breaking change because the build will break if mu_basecore v2025110002.0.8 is not updated to (or later) at the same time by consumers.