Add tensor size validation for MatMulBnb4 to prevent OOB read via K/N attribute mismatch#27995
Open
Add tensor size validation for MatMulBnb4 to prevent OOB read via K/N attribute mismatch#27995
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the MatMulBnb4 contrib operator against crafted models by validating that the b_quant and absmax tensors are large enough for the K/N/block_size attributes before dequantization, preventing potential out-of-bounds reads.
Changes:
- Add basic attribute validation for
K,N, andblock_sizein the CPU kernel constructor. - Add runtime size checks in
Compute()forb_quantandabsmaxbefore dequantization. - Add two regression tests that expect failure on undersized
b_quant/absmaxinputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| onnxruntime/contrib_ops/cpu/quantization/matmul_bnb4.cc | Adds size/attribute validation intended to prevent OOB reads during BNB4 dequantization on CPU. |
| onnxruntime/test/contrib_ops/matmul_bnb4_test.cc | Adds negative/regression tests that expect failures when b_quant/absmax are undersized vs K/N/block_size. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… attribute mismatch Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1caf670 to
3a8d28f
Compare
…ts to CPU EP Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validates that b_quant and absmax tensor sizes are consistent with K/N/block_size attributes before dequantization in the MatMulBnb4 operator.
Fixes https://portal.microsofticm.com/imp/v5/incidents/details/31000000559964/summary
Changes
Motivation and Context
MSRC case 109215: A crafted model can set K/N attributes larger than actual tensor sizes, causing OOB reads from b_quant_data and absmax_data during dequantization.