flowey: add capability to pass environment variables into the nix shell wrapper#3245
Open
justus-camp-microsoft wants to merge 1 commit intomicrosoft:mainfrom
Open
flowey: add capability to pass environment variables into the nix shell wrapper#3245justus-camp-microsoft wants to merge 1 commit intomicrosoft:mainfrom
justus-camp-microsoft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an escape hatch for Flowey’s nix-shell --pure --run command wrapper so callers can preserve selected environment variables inside the pure nix-shell environment.
Changes:
- Extend
CommandWrapperKind::NixShellwith akeep_varslist to pass through env vars vianix-shell --keep. - Update the reproducible-build pipeline job to specify the new field (currently empty).
- Add/adjust unit tests to cover the new wrapper rendering behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flowey/flowey_hvlite/src/pipelines/build_reproducible.rs | Updates nix-shell wrapper configuration to include the new keep_vars field. |
| flowey/flowey_core/src/shell.rs | Adds keep_vars to the serialized nix-shell wrapper and applies --keep args; expands wrapper display tests. |
damanm24
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, Nix won't pass any environment variables through to wrapped commands. There's an internal use-case for this, but in general this is a nice escape hatch to have.