Fix JSCRuntime invalidate() specifier ordering (noexcept before JSI_DISABLE_ASAN)#2967
Closed
Saadnajmi wants to merge 1 commit into
Closed
Conversation
…ISABLE_ASAN)
Clang requires noexcept to appear before compiler attributes like
__attribute__((no_sanitize("address"))). Having JSI_DISABLE_ASAN
(which expands to that attribute when ASAN is enabled) after noexcept
causes a build error:
error: expected function body after function declarator
Reorder to: noexcept JSI_DISABLE_ASAN across all four affected sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang requires `noexcept` to appear before compiler attributes like `attribute((no_sanitize("address")))`. Having `JSI_DISABLE_ASAN` (which expands to that attribute when ASAN is enabled) after `noexcept` causes a build error:\n\n```\nerror: expected function body after function declarator\n```\n\nReorder to: `noexcept JSI_DISABLE_ASAN` across all four affected sites.