Skip to content

fix(0.81, podspec): comment out duplicate scrollview subspec in React-FabricComponents #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Saadnajmi wants to merge 1 commit into
base: 0.81-stable
Choose a base branch
from
Draft

fix(0.81, podspec): comment out duplicate scrollview subspec in React-FabricComponents #2970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions packages/react-native/ReactCommon/React-FabricComponents.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,25 @@ Pod::Spec.new do |s|
sss.header_dir = "react/renderer/components/safeareaview"
end

ss.subspec "scrollview" do |sss|
sss.source_files = podspec_sources(["react/renderer/components/scrollview/*.{m,mm,cpp,h}",
"react/renderer/components/scrollview/platform/cxx/**/*.{m,mm,cpp,h}"],
["react/renderer/components/scrollview/*.h",
"react/renderer/components/scrollview/platform/cxx/**/*.h"])
sss.exclude_files = "react/renderer/components/scrollview/tests"
sss.header_dir = "react/renderer/components/scrollview"
end
# [macOS The "scrollview" subspec below duplicates source_files already declared in
# React-Fabric.podspec's "scrollview" subspec (which uses a recursive
# `react/renderer/components/scrollview/**/*` glob). The overlap causes
# ScrollViewShadowNode.cpp and friends to be compiled into both the
# React-Fabric and React-FabricComponents Pods targets, breaking consumers
# that link both libraries via `-all_load` (duplicate symbols). Comment it
# out here so scrollview is only built into React-Fabric -- where
# React-Fabric's mounting/internal/CullingContext.cpp already needs
# ScrollViewShadowNode anyway.
#
# ss.subspec "scrollview" do |sss|
# sss.source_files = podspec_sources(["react/renderer/components/scrollview/*.{m,mm,cpp,h}",
# "react/renderer/components/scrollview/platform/cxx/**/*.{m,mm,cpp,h}"],
# ["react/renderer/components/scrollview/*.h",
# "react/renderer/components/scrollview/platform/cxx/**/*.h"])
# sss.exclude_files = "react/renderer/components/scrollview/tests"
# sss.header_dir = "react/renderer/components/scrollview"
# end
# macOS]

ss.subspec "text" do |sss|
sss.source_files = podspec_sources(["react/renderer/components/text/*.{m,mm,cpp,h}",
Expand Down
Loading