Build Linux language extensions with GCC 13 on the RHEL 9 baseline

language-extensions/R/src/CMakeLists.txt

@@ -31,12 +31,27 @@ file(GLOB REXTENSION_SOURCE_FILES
 	${REXTENSION_HOME}/common/src/*.cpp
 	${REXTENSION_SRC_DIR}/${PLATFORM}/*.cpp)
 
+# RHEL 9 ABI floor shims. Required because libstdc++.a and libgcc.a from the
+# Ubuntu 24.04 toolchain reference glibc symbols newer than 2.34. See
+# language-extensions/common/linux/AbiFloorCompat_linux.cpp.
+#
+if (${PLATFORM} STREQUAL linux)
+	list(APPEND REXTENSION_SOURCE_FILES ${ENL_ROOT}/language-extensions/common/linux/AbiFloorCompat_linux.cpp)
+endif()
+
 # Create the target library
 #
 add_library(RExtension SHARED
 	${REXTENSION_SOURCE_FILES}
 )
 
+# R links libstdc++ dynamically, so RHEL9's 3.4.29 copy will not provide
+# std::ios_base_library_init(). Ask the shared compat unit to define it.
+#
+if (${PLATFORM} STREQUAL linux)
+	target_compile_definitions(RExtension PRIVATE ABI_FLOOR_PROVIDE_IOS_BASE_LIBRARY_INIT)
+endif()
+
 set_target_properties(RExtension
 	PROPERTIES
 	VERSION ${REXTENSION_VERSION}
@@ -47,17 +62,29 @@ if (${PLATFORM} STREQUAL linux)
 	target_compile_options(RExtension PRIVATE -Wall -Wextra -g -fPIC -Werror
 		-std=c++17 -Wno-unused-parameter -Wno-cast-function-type -Wno-format-overflow 
 		-Wno-deprecated-copy -Wno-sign-conversion -Wno-conversion -Wno-maybe-uninitialized)
+	# RHEL9 ABI floor (GLIBCXX <= 3.4.29): GCC 13 emits a reference to
+	# std::ios_base_library_init()@GLIBCXX_3.4.32 into any translation unit that
+	# includes <iostream>. The RExtension sources no longer include it directly,
+	# but the Rcpp and RInside headers do, so the reference cannot be removed at
+	# the source level.
+	#
+	# libstdc++ is deliberately NOT linked statically here. libR.so already links
+	# libstdc++.so.6, so a static copy would put two C++ runtimes in one process
+	# and the R extension aborts (SIGABRT) part-way through a script execution.
+	# -Wl,-z,nodelete does not help: the fault is duplication, not unload order.
+	# The single offending symbol is instead defined locally in
+	# language-extensions/common/linux/AbiFloorCompat_linux.cpp.
 	set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--as-needed \
 		-Wl,--export-dynamic -fopenmp -Wl,-rpath,'${ORIGIN}'")
 	set(CMAKE_FIND_LIBRARY_SUFFIXES "${CMAKE_FIND_LIBRARY_SUFFIXES};.so.1;.so.3;.so.5")
-	set(USR_LIB_PATH "/usr/lib/x86_64-linux-gnu")
+	set(USR_LIB_PATH "/usr/lib64")
 
 	# Find dependent libraries with fallback paths
 	#
-	find_library(PCRE_LIB NAMES pcre libpcre PATHS ${USR_LIB_PATH} /usr/lib /lib NO_DEFAULT_PATH)
-	find_library(LZMA_LIB NAMES lzma liblzma PATHS ${USR_LIB_PATH} /usr/lib /lib NO_DEFAULT_PATH)
-	find_library(BZ2_LIB NAMES bz2 libbz2 PATHS ${USR_LIB_PATH} /usr/lib /lib NO_DEFAULT_PATH)
-	find_library(Z_LIB NAMES z libz PATHS ${USR_LIB_PATH} /usr/lib /lib NO_DEFAULT_PATH)
+	find_library(PCRE_LIB NAMES pcre libpcre PATHS ${USR_LIB_PATH} /usr/lib /lib /usr/lib/x86_64-linux-gnu NO_DEFAULT_PATH)
+	find_library(LZMA_LIB NAMES lzma liblzma PATHS ${USR_LIB_PATH} /usr/lib /lib /usr/lib/x86_64-linux-gnu NO_DEFAULT_PATH)
+	find_library(BZ2_LIB NAMES bz2 libbz2 PATHS ${USR_LIB_PATH} /usr/lib /lib /usr/lib/x86_64-linux-gnu NO_DEFAULT_PATH)
+	find_library(Z_LIB NAMES z libz PATHS ${USR_LIB_PATH} /usr/lib /lib /usr/lib/x86_64-linux-gnu NO_DEFAULT_PATH)
 	find_library(RT_LIB rt ${USR_LIB_PATH})
 	find_library(DL_LIB dl ${USR_LIB_PATH})
 	find_library(M_LIB m ${USR_LIB_PATH})

language-extensions/R/src/Logger.cpp

@@ -27,7 +27,6 @@
 //**************************************************************************************************
 
 #include <ctime>
-#include <iostream>
 #include <stdio.h>
 
 #include "Common.h"
@@ -75,7 +74,7 @@ void Logger::Log(const string &msg)
 {
 #if defined(_DEBUG) || defined(_VERBOSE)
 	string msgWithTimestamp = string(GetCurrentTimestamp()) + msg + "\n";
-	cout << msgWithTimestamp;
+	fputs(msgWithTimestamp.c_str(), stdout);
 #endif
 }
 
@@ -136,9 +135,9 @@ const char* Logger::GetCurrentTimestamp()
 //
 // Description:
 //  Logs the given message to stderr; if R is initialized uses its error printing function,
-//  else uses std::cerr.
+//  else writes directly to stderr.
 //
 void Logger::LogToStdErr(const string &errorMsgWithTimestamp)
 {
-	cerr << errorMsgWithTimestamp;
+	fputs(errorMsgWithTimestamp.c_str(), stderr);
 }

language-extensions/R/src/RExtension.cpp

@@ -29,7 +29,6 @@
 #include "Common.h"
 
 #include <cstring>
-#include <iostream>
 #include <stdexcept>
 #include <unordered_map>
 

language-extensions/R/src/RTypeUtils.cpp

@@ -28,7 +28,6 @@
 #include "Common.h"
 #include <climits>
 #include <cmath>
-#include <iostream>
 
 #include "RTypeUtils.h"
 #include "Unicode.h"

language-extensions/R/test/src/RExtensionGetResultColumnTests.cpp

@@ -475,8 +475,9 @@ namespace ExtensionApiTest
 		//
 		vector<char> chineseBytes = { -28, -67, -96, -27, -91, -67 };
 		string chineseString = string(chineseBytes.data(), 6);
+		string worldChineseString = "World" + chineseString;
 
-		vector<const char*> charCol1{ "Hello", "test", "data", ("World" + chineseString).c_str(),
+		vector<const char*> charCol1{ "Hello", "test", "data", worldChineseString.c_str(),
 			chineseString.c_str() };
 		vector<const char*> charCol2{ "", 0, nullptr, "verify", "-1" };
 

language-extensions/common/linux/AbiFloorCompat_linux.cpp

@@ -0,0 +1,201 @@
+//**************************************************************************************************
+// @File: AbiFloorCompat_linux.cpp
+//
+// Purpose:
+//  RHEL 9 ABI floor compatibility shims for Linux language extensions.
+//
+//  The extensions are built on Ubuntu 24.04 (glibc 2.38, GCC 13) but must load
+//  on RHEL 9 (glibc 2.34). A small number of symbols above that floor get pulled
+//  in by the toolchain rather than by our own code, so they cannot be removed at
+//  the call site:
+//
+//    __isoc23_strtoll  @GLIBC_2.38  glibc 2.38 <stdlib.h> redirects the strtol
+//    __isoc23_strtoull @GLIBC_2.38  family to C23 variants; the references come
+//    __isoc23_strtoul  @GLIBC_2.38  from vendored headers and from libstdc++.a
+//    arc4random        @GLIBC_2.36  used by libstdc++.a
+//    _dl_find_object   @GLIBC_2.35  used by the libgcc.a unwinder
+//
+//  Each shim is defined under a distinct C++ name carrying an __asm__ label, so
+//  the emitted symbol is the glibc name. Defining a function literally named
+//  __isoc23_strtoll does NOT work: <stdlib.h> has already declared strtoll with
+//  that same assembler name, and the resulting conflict leaves the reference
+//  unresolved (observed as "UND __isoc23_strtoll@GLIBC_2.38" in .dynsym).
+//
+//  Every shim is hidden. They satisfy references inside this shared object only
+//  and are not exported, so this library never interposes on glibc for the rest
+//  of the host process.
+//
+//  Enforced by build/linux/validate-native-elf.sh (MAX GLIBC <= 2.34).
+//**************************************************************************************************
+
+#if defined(__linux__)
+
+// <features.h> (pulled in by any libc header) must be included before testing
+// __GLIBC__: the macro is defined by glibc's headers, not by the compiler.
+// Guarding on __GLIBC__ before any include silently compiles this whole file to
+// nothing, which is exactly how an earlier revision of these shims ended up
+// linked but inert.
+#include <errno.h>
+#include <fcntl.h>
+#include <stdint.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/random.h>
+#include <unistd.h>
+
+#if defined(__GLIBC__)
+
+#ifdef ABI_FLOOR_PROVIDE_IOS_BASE_LIBRARY_INIT
+// For std::ios_base::Init, which is what actually constructs the standard
+// streams. See AbiFloorIosBaseLibraryInit below.
+#include <ios>
+#endif
+
+#define ABI_FLOOR_HIDDEN __attribute__((visibility("hidden")))
+
+extern "C"
+{
+	// Bind to the classic, always-present glibc entry points. The explicit
+	// assembler labels bypass the <stdlib.h> C23 redirect, so these cannot
+	// recurse back into the shims below.
+	long long int AbiFloorClassicStrtoll(const char *nptr, char **endptr, int base) __asm__("strtoll");
+	unsigned long long int AbiFloorClassicStrtoull(const char *nptr, char **endptr, int base) __asm__("strtoull");
+	unsigned long int AbiFloorClassicStrtoul(const char *nptr, char **endptr, int base) __asm__("strtoul");
+
+	ABI_FLOOR_HIDDEN long long int AbiFloorIsoc23Strtoll(const char *nptr, char **endptr, int base) __asm__("__isoc23_strtoll");
+	ABI_FLOOR_HIDDEN unsigned long long int AbiFloorIsoc23Strtoull(const char *nptr, char **endptr, int base) __asm__("__isoc23_strtoull");
+	ABI_FLOOR_HIDDEN unsigned long int AbiFloorIsoc23Strtoul(const char *nptr, char **endptr, int base) __asm__("__isoc23_strtoul");
+	ABI_FLOOR_HIDDEN uint32_t AbiFloorArc4Random(void) __asm__("arc4random");
+	ABI_FLOOR_HIDDEN int AbiFloorDlFindObject(void *address, void *result) __asm__("_dl_find_object");
+
+	// The only behavioural difference between the C23 and classic strtol forms
+	// is that the C23 forms also accept a "0b" binary prefix when base is 0 or
+	// 2. No caller in these extensions parses binary literals.
+	ABI_FLOOR_HIDDEN long long int AbiFloorIsoc23Strtoll(const char *nptr, char **endptr, int base)
+	{
+		return AbiFloorClassicStrtoll(nptr, endptr, base);
+	}
+
+	ABI_FLOOR_HIDDEN unsigned long long int AbiFloorIsoc23Strtoull(const char *nptr, char **endptr, int base)
+	{
+		return AbiFloorClassicStrtoull(nptr, endptr, base);
+	}
+
+	ABI_FLOOR_HIDDEN unsigned long int AbiFloorIsoc23Strtoul(const char *nptr, char **endptr, int base)
+	{
+		return AbiFloorClassicStrtoul(nptr, endptr, base);
+	}
+
+	// arc4random is a cryptographically secure generator, so this must not
+	// degrade to a weak source. getrandom(2) is the kernel CSPRNG and has been
+	// available since glibc 2.25, well under the RHEL 9 floor. /dev/urandom is
+	// the fallback for seccomp-restricted environments. If neither can produce
+	// bytes we abort rather than return predictable output.
+	ABI_FLOOR_HIDDEN uint32_t AbiFloorArc4Random(void)
+	{
+		uint32_t value = 0;
+		unsigned char *out = reinterpret_cast<unsigned char *>(&value);
+		size_t filled = 0;
+
+		while (filled < sizeof(value))
+		{
+			ssize_t received = getrandom(out + filled, sizeof(value) - filled, 0);
+			if (received < 0)
+			{
+				if (errno == EINTR)
+				{
+					continue;
+				}
+				break;
+			}
+			filled += static_cast<size_t>(received);
+		}
+
+		if (filled < sizeof(value))
+		{
+			int fd = open("/dev/urandom", O_RDONLY | O_CLOEXEC);
+			if (fd >= 0)
+			{
+				while (filled < sizeof(value))
+				{
+					ssize_t received = read(fd, out + filled, sizeof(value) - filled);
+					if (received <= 0)
+					{
+						if (received < 0 && errno == EINTR)
+						{
+							continue;
+						}
+						break;
+					}
+					filled += static_cast<size_t>(received);
+				}
+				close(fd);
+			}
+		}
+
+		if (filled < sizeof(value))
+		{
+			abort();
+		}
+
+		return value;
+	}
+
+	// _dl_find_object is the glibc 2.35+ fast path the libgcc unwinder uses to
+	// locate exception-handling frames. A non-zero return means "no information
+	// available", which makes libgcc fall back to its dl_iterate_phdr path. That
+	// fallback is the same code path used on every glibc older than 2.35, so
+	// unwinding stays correct - only marginally slower on the throw path.
+	ABI_FLOOR_HIDDEN int AbiFloorDlFindObject(void *address, void *result)
+	{
+		(void)address;
+		(void)result;
+		return -1;
+	}
+
+	// std::ios_base_library_init() is GLIBCXX_3.4.32, i.e. GCC 13's libstdc++.
+	// GCC 13 emits a reference to it from every translation unit that includes
+	// <iostream>, and RHEL9's libstdc++ 3.4.29 does not provide it.
+	//
+	// This is opt-in via ABI_FLOOR_PROVIDE_IOS_BASE_LIBRARY_INIT because it must
+	// only be defined when libstdc++ is linked *dynamically*. libstdc++.a already
+	// contains this symbol in ios_init.o, so defining it alongside a static
+	// libstdc++ fails the link with "multiple definition of
+	// std::ios_base_library_init()".
+	//
+	// The R and Python extensions are the cases that need it: neither can link
+	// libstdc++ statically (libR.so already links libstdc++.so.6, and numpy's and
+	// pandas' C extensions do too - two C++ runtimes in one process abort at
+	// runtime), yet the include is unavoidable because it arrives through the
+	// Rcpp/RInside and Boost.Python headers.
+	//
+	// This MUST NOT be a no-op. GCC 13 changed how the standard streams are
+	// constructed: before 13, every TU including <iostream> emitted its own static
+	// std::ios_base::Init object; GCC 13 emits a call to this function instead and
+	// performs the construction inside libstdc++. So on a host whose libstdc++ is
+	// 3.4.32 or newer the library initialises the streams itself and a stub here
+	// looks harmless - but on Ubuntu 22.04 (libstdc++.so.6.0.30) and RHEL 9 nothing
+	// initialises them, std::cout/std::cerr stay unconstructed, and the first write
+	// crashes the satellite process. That is precisely how libPythonExtension died
+	// on Ubuntu 22.04 and RHEL 9 while passing on Ubuntu 24.04, RHEL 10 and
+	// AzureLinux 3, which ship newer libstdc++.
+	//
+	// Constructing a function-local static std::ios_base::Init performs the pre-13
+	// initialisation explicitly. Its constructor is refcounted and idempotent, the
+	// local static guard runs it exactly once however many translation units call
+	// in, and std::ios_base::Init::Init is GLIBCXX_3.4 - present in every libstdc++
+	// we target, so this does not raise the ABI floor.
+#ifdef ABI_FLOOR_PROVIDE_IOS_BASE_LIBRARY_INIT
+	ABI_FLOOR_HIDDEN void AbiFloorIosBaseLibraryInit(void) __asm__("_ZSt21ios_base_library_initv");
+	ABI_FLOOR_HIDDEN void AbiFloorIosBaseLibraryInit(void)
+	{
+		static std::ios_base::Init iosBaseInit;
+		(void)iosBaseInit;
+	}
+#endif
+}
+
+#else
+#error "AbiFloorCompat_linux.cpp is compiled for Linux but __GLIBC__ is not defined; the shims would be silently empty."
+#endif // __GLIBC__
+#endif // __linux__

language-extensions/java/src/CMakeLists.txt

@@ -32,6 +32,14 @@ file(TO_CMAKE_PATH ${ENL_ROOT}/extension-host/include EXTENSION_API_INCLUDE_DIR)
 #
 file(GLOB JAVAEXTENSION_SOURCE_FILES ${JAVAEXTENSION_SRC_DIR}/*.cpp ${JAVAEXTENSION_SRC_DIR}/${PLATFORM}/*.cpp)
 
+# RHEL 9 ABI floor shims. Required because libstdc++.a and libgcc.a from the
+# Ubuntu 24.04 toolchain reference glibc symbols newer than 2.34. See
+# language-extensions/common/linux/AbiFloorCompat_linux.cpp.
+#
+if (${PLATFORM} STREQUAL linux)
+    list(APPEND JAVAEXTENSION_SOURCE_FILES ${ENL_ROOT}/language-extensions/common/linux/AbiFloorCompat_linux.cpp)
+endif()
+
 # Create the target library
 #
 add_library(JavaExtension SHARED
@@ -45,7 +53,11 @@ set_target_properties(JavaExtension
 )
 
 if (${PLATFORM} STREQUAL linux)
-	file(TO_CMAKE_PATH ${JAVA_HOME}/jre/lib/amd64/server JRE_ROOT)
+	if(EXISTS "${JAVA_HOME}/lib/server")
+		file(TO_CMAKE_PATH ${JAVA_HOME}/lib/server JRE_ROOT)
+	else()
+		file(TO_CMAKE_PATH ${JAVA_HOME}/jre/lib/amd64/server JRE_ROOT)
+	endif()
 	file(TO_CMAKE_PATH ${JAVA_HOME}/include JDK_INCLUDE)
 	file(TO_CMAKE_PATH ${JDK_INCLUDE}/linux JDK_INCLUDE_LINUX)
 
@@ -63,14 +75,8 @@ if (${PLATFORM} STREQUAL linux)
 
 	target_compile_options(JavaExtension PRIVATE ${CXXFLAGS})
 
-	set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -shared -L${OUTPUT_DIRECTORY}/lib -L${LIBS} -Wl,-rpath,${JRE_ROOT}:/opt/mssql-extensibility/lib")
-	set(USR_LIB_PATH "/usr/local/lib")
-
-	find_library(CXX_LIB c++ ${USR_LIB_PATH})
-	find_library(ABI_LIB c++abi ${USR_LIB_PATH})
-	find_library(DL_LIB dl ${USR_LIB_PATH})
-
-	target_link_libraries(JavaExtension ${CXX_LIB} ${ABI_LIB} ${DL_LIB})
+	set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -shared -static-libstdc++ -static-libgcc -Wl,--exclude-libs,ALL -Wl,-rpath,${JRE_ROOT}:/opt/mssql-extensibility/lib")
+	target_link_libraries(JavaExtension dl)
 	set(ADDITIONAL_INCLUDES ${JDK_INCLUDE} ${JDK_INCLUDE_LINUX})
 
 elseif(${PLATFORM} STREQUAL windows)