Normalize reused string-literal property names to identifiers in declaration emit#3965
Draft
Copilot wants to merge 3 commits into
Draft
Normalize reused string-literal property names to identifiers in declaration emit#3965Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/7d1adf6f-bbb8-49ca-88de-d1ae13f7a91b Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/7d1adf6f-bbb8-49ca-88de-d1ae13f7a91b Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix property names quoting in inferred type
Normalize reused string-literal property names to identifiers in declaration emit
May 18, 2026
RyanCavanaugh
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaration emit produced inconsistent property-name quoting when a nested object type was reused from source: top-level properties (rebuilt via
typeToTypeNode) emitted as identifiers, while nested properties (reused viapseudoTypeToNode) preserved the user's string-literal form even when the text was a valid identifier.Changes
internal/checker/nodecopy.go—reuseNamenow normalizes a reusedStringLiteralwhose text is a valid identifier into anIdentifier, matchingcreatePropertyNameNodeForIdentifierOrLiteralused on the fresh-construction path. The name"new"is excluded so reused"new"(): voidmethod signatures aren't rewritten into construct signatures (mirroring the existingisMethodNamedNewguard).escapedReservedCompilerNamedIdentifier.js,jsDeclarationsPackageJson(target=es2015).types) now match strada exactly; their.difffiles and the correspondingsubmoduleAccepted.txtentry were removed.testdata/tests/cases/compiler/declarationEmitStringNamedPropertyConsistency.tscovers the reported repro.