Avoid fatal panic on stale config-retainer project paths in project rebuild flow#3987
Draft
Copilot wants to merge 3 commits into
Draft
Avoid fatal panic on stale config-retainer project paths in project rebuild flow#3987Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and reproduce fatal server crash in markProjectsAffectedByConfigChanges
Avoid fatal panic on stale config-retainer project paths in project rebuild flow
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A server crash was occurring in
markProjectsAffectedByConfigChangeswhen config-change bookkeeping referenced a configured project path that no longer existed in the builder map. This made snapshot updates crash instead of continuing through a recoverable stale-state condition.Crash condition
markProjectsAffectedByConfigChangesassumed every entry inconfigChangeResult.affectedProjectswas present inconfiguredProjects.Behavior change
affectedProjectsis not inconfiguredProjects, log and continue.dirtyFilePath).Regression coverage
TestProjectCollectionBuilder_HandlesStaleConfigRetainerin:internal/project/projectcollectionbuilder_panic_repro_test.go