Keep terminal task icon when holding Alt - #332372
Draft
Anthony Kim (anthonykim1) wants to merge 1 commit into
Draft
Keep terminal task icon when holding Alt#332372Anthony Kim (anthonykim1) wants to merge 1 commit into
Anthony Kim (anthonykim1) wants to merge 1 commit into
Conversation
Preserve the active terminal label's primary icon while retaining the alternate Split command semantics and Alt-click behavior.\n\nFixes #332359\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Keeps the active terminal’s task identity visually stable while retaining alternate Split Terminal behavior.
Changes:
- Always render the primary terminal icon and label.
- Preserve alternate-command tooltip, accessible label, and Alt-click execution.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/terminal/browser/terminalView.ts |
Uses the primary action icon when rendering the active terminal label. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #332359
Inspirations from:
MenuEntryActionViewItem.SingleTerminalTabActionViewItem.