Skip to content

terminal: hide View in Chat for Agent Host sessions - #332446

Open
Connor Peet (connor4312) wants to merge 2 commits into
mainfrom
connor4312/332433
Open

terminal: hide View in Chat for Agent Host sessions#332446
Connor Peet (connor4312) wants to merge 2 commits into
mainfrom
connor4312/332433

Conversation

@connor4312

Copy link
Copy Markdown
Member

terminal: hide View in Chat for Agent Host sessions

Terminal Chat Agent Host sessions are ephemeral and cannot be opened reliably in the Chat panel.

  • Tracks whether each Terminal Chat widget uses an Agent Host session.
  • Hides the View in Chat action from menus and accessible actions for those sessions.
  • Keeps the action available for local Terminal Chat sessions.
  • Adds regression coverage for both session types.

Fixes #332433

(Commit message generated by Copilot)

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Terminal Chat Agent Host sessions are ephemeral and cannot be opened reliably in the Chat panel.

- Tracks whether each Terminal Chat widget uses an Agent Host session.
- Hides the View in Chat action from menus and accessible actions for those sessions.
- Keeps the action available for local Terminal Chat sessions.
- Adds regression coverage for both session types.

Fixes #332433

(Commit message generated by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 24, 2026 23:19
@connor4312
Connor Peet (connor4312) enabled auto-merge (squash) August 24, 2026 23:19
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Anthony Kim (@anthonykim1)

Matched files:

  • src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChat.ts
  • src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatActions.ts
  • src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatWidget.ts
  • src/vs/workbench/contrib/terminalContrib/chat/test/browser/terminalChatActions.test.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prevents unreliable “View in Chat” navigation for ephemeral Agent Host terminal sessions while preserving it for local sessions.

Changes:

  • Tracks Agent Host usage with a terminal chat context key.
  • Hides the action from menus and accessible actions.
  • Adds regression coverage for local and Agent Host sessions.
Show a summary per file
File Description
terminalChatActions.test.ts Tests action visibility by session type.
terminalChatWidget.ts Maintains the Agent Host context state.
terminalChatActions.ts Gates “View in Chat” on that state.
terminalChat.ts Defines the new context key.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal Chat: "Open In Chat" eventually leads to a session that disappears

4 participants