sessions: support Open Chat Agent keybinding - #332448
Merged
roblourens merged 5 commits intoAug 25, 2026
Merged
Conversation
Route the Open Chat (Agent) shortcuts to Focus Active Session in the Agents Window, preserving the Linux formatting shortcut and documenting the alias in accessibility help. Add cross-platform keybinding coverage.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Routes platform-specific Open Chat (Agent) shortcuts to the active Agents Window session.
Changes:
- Adds shared Focus Active Session command ID and keybindings.
- Documents the shortcut in accessibility help.
- Adds cross-platform keybinding tests.
Show a summary per file
| File | Description |
|---|---|
sessionCommands.ts |
Defines the shared command ID. |
sessionsActions.ts |
Registers platform-specific shortcuts. |
sessionsChatAccessibilityHelp.ts |
Documents focus behavior. |
sessionsFocusActiveSessionKeybinding.test.ts |
Tests platform bindings. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Balanced
Clarify that the copied Open Chat Agent chord is a default binding, and compare the Sessions alias directly against the registered cross-platform command defaults. Verify the Linux Format Document command retains Ctrl+Shift+I.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Share the Open Chat Agent default keybinding between the workbench and Sessions registrations so the regression test can compare defaults without registering the full Chat action catalog. This avoids changing global command state in aggregate browser tests.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the platform-specific alias explicit in the Sessions action and test instead of exporting a shared workbench keybinding constant.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore the existing explanation for why Focus Active Session uses the Sessions keybinding weight.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
marked this pull request as ready for review
August 25, 2026 00:59
roblourens
enabled auto-merge (squash)
August 25, 2026 00:59
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run typecheck-client./scripts/test.sh src/vs/sessions/contrib/sessions/test/browser/sessionsFocusActiveSessionKeybinding.test.ts src/vs/sessions/contrib/sessions/test/browser/sessionsReopenKeybinding.test.ts(Written by Copilot)