fix: guard against ambiguous food write retries - #39
Merged
Merged
Conversation
Co-authored-by: Dan <miller0daniel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incident analysis
The earlier agent launched quick-add twice after receiving only 30 seconds of progress output. Its execution wrapper returned only output and discarded process/session metadata. It inspected the diary before establishing that the original write had finished, then incorrectly treated absence as a completed failure. The user confirmed both writes ultimately saved. This primarily requires an agent/prompt fix; SDK retries and ambiguous empty export output are additional code-level risks, not proven causes of this incident. Companion Promptr branch: tembo/safe-crono-verification.
Validation