chore(upstream): pin ET #792 SO_LINGER (skip) - #85
Merged
Conversation
Classify 584a68b as security/skip. et.rs never sets SO_LINGER and has no process-wide mutex around close, so default linger-off already matches. PROTOCOL_VERSION stays 6. Co-authored-by: Woonggi Min <minpeterx@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Weekday EternalTerminal watch: classify MisterTea/EternalTerminal#792 (
584a68b4b54c74de7035e6108f49151ebce6a191, 2026-09-03) as security / skip. Pin ≠ ported.Upstream C++ set
SO_LINGER {l_onoff=1, l_linger=5}on every accepted TCP socket, then held process-wideglobalMutexacross a blocking::close(). That froze the whole socket layer for ~5 seconds. The C++ fix only flipsl_onofffrom1to0insrc/base/TcpSocketHandler.cpp.et.rs already matches that outcome:
SO_LINGER/so_linger(never enables linger)socket2/TcpStreamwith nodelay/buffer opts onlyUnixSocketHandler::closeDo not add a
SO_LINGERsetsockopt just to set it off. No C++ merge. No Rust production change. Nowire.jsonedit.PROTOCOL_VERSIONstays 6. Tags remainet-v7.0.0/7656a32…. No GHSA found.Pin / ledger
584a68b4b54c74de7035e6108f49151ebce6a191et-v7.0.0@7656a32a5bc15c6746726a27a5a4ba1e468fab6e7656a32...masterahead_by16, all classifiedFiles
.github/upstream-ledger.yml— append584a68b;classified: 2026-09-04.github/upstream-pin.yml— tip + reviewed datedocs/upstream-pin.md— table row, tip SHA, datesVerification
python3 scripts/check-upstream-ledger.py --self-testpython3 scripts/check-upstream-ledger.py(comparebaseline...masterhas no unclassified SHAs; pin tip == master)Summary by cubic
Classifies EternalTerminal #792 (disable
SO_LINGER) as security/skip and updates the upstream pin.et.rs never sets
SO_LINGERand has no process-wide mutex around close, so the default linger-off already matches the C++ fix. No production code changes;PROTOCOL_VERSIONstays 6.Written for commit 32a5d66. Summary will update on new commits.