Add mmtk_collection_in_progress C API#313
Open
topolarity wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API seems sufficient for Julia to implement a "disable-GC-and-wait-for-finish" API, e.g.:
Effectively spinlocking on this condition is not great, but I am OK with cleaning that up in a future re-factor.
I'd also be fine to implement #301 or another re-factor instead.
The only trouble is that those APIs seem to focus on disabling GC triggers or disabling GC stop-the-world, which is not sufficient for true GC-must-not-run critical sections. This API is intended to be used if you want to disable new GC and are willing to wait for ongoing GC to finish to make sure it is not running at all.