Add CommandLineArguments unit tests

Author: javierbrea

jest.config.js

@@ -17,10 +17,10 @@ module.exports = {
   // An object that configures minimum threshold enforcement for coverage results
   coverageThreshold: {
     global: {
-      branches: 60,
-      functions: 70,
-      lines: 70,
-      statements: 70
+      branches: 70,
+      functions: 75,
+      lines: 75,
+      statements: 75
     }
   },
 
@@ -42,9 +42,10 @@ module.exports = {
     "**/test/unit/core/mocks/Behaviors.spec.js",
     "**/test/unit/core/mocks/FilesHandler.spec.js",
     "**/test/unit/core/mocks/Mocks.spec.js",
-    "**/test/unit/core/server/Server.spec.js"
+    "**/test/unit/core/server/Server.spec.js",
+    "**/test/unit/core/settings/CommandLineArguments.spec.js"
   ],
-  //testMatch: ["**/test/unit/core/server/Server.spec.js"],
+  //testMatch: ["**/test/unit/core/settings/CommandLineArguments.spec.js"],
 
   // The test environment that will be used for testing
   testEnvironment: "node"

lib/core/settings/CommandLineArguments.js

@@ -26,7 +26,7 @@ class CommandLineArguments {
       .option("--host <host>", "Host for server")
       .option("--log <log>", "Log level")
       .option("--port <port>", "Port for server", parseInt)
-      .option("--watch", "Watch or not", this._stringToBoolean)
+      .option("--watch <watch>", "Watch or not", this._stringToBoolean) // TODO, change by --no-watch option
       // TODO, remove deprecated options
       .option("--feature <feature>", "Define current behavior")
       .option("--features <features>", "Define folder from which load behaviors");
@@ -40,10 +40,11 @@ class CommandLineArguments {
     return Promise.resolve();
   }
 
+  // TODO, deprecate "stringBoolean" options. Use --no- commander feature
   _stringToBoolean(val) {
-    if (val === "true") {
+    if (isUndefined(val) || val === "true") {
       return true;
-    } else if (isUndefined(val) || val === "false") {
+    } else if (val === "false") {
       return false;
     }
     throw new Error("Invalid boolean value");
@@ -59,19 +60,16 @@ class CommandLineArguments {
   }
 
   addCustom(optionDetails) {
-    const optionValueGetter =
-      optionDetails.type === "string" || optionDetails.type === "booleanString"
-        ? ` <${optionDetails.name}>`
-        : "";
+    const optionPrefix =
+      optionDetails.type === "boolean" && optionDetails.default === true ? "--no-" : "--";
+    const optionValueGetter = optionDetails.type === "boolean" ? "" : ` <${optionDetails.name}>`;
     const optionParser = optionDetails.parse
       ? optionDetails.parse
       : optionDetails.type === "number"
       ? parseInt
       : optionDetails.type === "booleanString"
       ? this._stringToBoolean
       : undefined;
-    const optionPrefix =
-      optionDetails.type === "boolean" && optionDetails.default === true ? "--no-" : "--";
 
     this._commander.option(
       `${optionPrefix}${optionDetails.name}${optionValueGetter}`,

test/acceptance/main/InteractiveCliRunner.js

@@ -1,3 +1,13 @@
+/*
+Copyright 2019 Javier Brea
+
+Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+*/
+
 const { CliRunner, wait } = require("./utils");
 
 const LOG = "[CLI]: ";