feat: properly impl find for files#5741
Merged
IMB11 merged 12 commits intomodrinth:mainfrom Apr 16, 2026
Merged
Conversation
Member
Pull request changelogAppAddedChanged
DeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChanged
DeprecatedRemovedFixedSecurity |
creeperkatze
changed the title
Contributor
Author
|
Fixed lint |
creeperkatze
changed the title
Member
|
Hi, this looks good, can you resolve the conflicts? Thanks |
Signed-off-by: Arthur <creeperkatze.dev@gmail.com>
IMB11
requested changes
Apr 15, 2026
Member
IMB11
left a comment
IMB11
left a comment
There was a problem hiding this comment.
Just some things that need changing other than that looks good
Contributor
Author
|
Fixed! |
Contributor
Author
|
Slight adjustment, the results label is now oriented left |
IMB11
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a find and replace ui for files, using the internal functions from the ace editor.
Before, pressing Ctrl+F just showed the internal, ugly ui.
Example.mp4
Closes #5699