Skip to content

Fix scan-to-compile pinning format propagation - #5

Merged
joakimmoller merged 3 commits into
mainfrom
p96
May 3, 2026
Merged

Fix scan-to-compile pinning format propagation#5
joakimmoller merged 3 commits into
mainfrom
p96

Conversation

@joakimmoller

Copy link
Copy Markdown

Summary

  • propagate scan job pinning formats to compile job creation in ScannerEffector by setting overwrite_pinning_matrices from scanning_job.pinning_formats
  • add regression tests that verify pinning formats are copied into the compile model and serialized into the RPC compile payload
  • bump project version from 3.1.0 to 3.1.1 and update uv.lock

Why

Compile jobs created from scan flows could miss pinning format overrides, causing downstream compilation/analysis to run with unintended pinning matrices.

Changes

  • update ScannerEffector setup path to include overwrite_pinning_matrices when creating compile project model
  • add unit tests in tests/unit/server/test_scanning_effector.py:
    • setup copies scan pinning formats to compile model
    • compile request payload includes overwrite_pinning_matrices

Validation

  • uv run pytest tests/unit/server/test_scanning_effector.py -q
  • result: 2 passed

Impact

  • aligns compile behavior with scan configuration
  • reduces risk of incorrect pinning interpretation during analysis for non-default pinning layouts
  • low risk: targeted change with direct test coverage

joakimmoller and others added 3 commits May 4, 2026 00:03
Pass scan pinning_formats through to compile jobs via overwrite_pinning_matrices so downstream compilation uses the intended pinning matrices.

Add regression tests for ScannerEffector setup and compile payload propagation.

Bump project version to 3.1.1 and update uv.lock.
Run a focused ty-fix round for scan compilation flow and related models/tests.

- Fix scanner mail helper to return str (not tuple)

- Correct scan cycle disk-space step mapping

- Add optional-safety guards for scanner, pipe effector, compile model and current image

- Align model typing for optional current_image and mutable compile image list

- Keep ScannerEffector/tests ty-clean while preserving scan behavior

- Verify with pytest tests/unit/server/test_scanning_effector.py and focused ty checks
Co-authored-by: Copilot <copilot@github.com>
@joakimmoller
joakimmoller merged commit 54098f4 into main May 3, 2026
12 checks passed
@joakimmoller
joakimmoller deleted the p96 branch May 3, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant