Fix scan-to-compile pinning format propagation - #5
Merged
Merged
Conversation
Pass scan pinning_formats through to compile jobs via overwrite_pinning_matrices so downstream compilation uses the intended pinning matrices. Add regression tests for ScannerEffector setup and compile payload propagation. Bump project version to 3.1.1 and update uv.lock.
Run a focused ty-fix round for scan compilation flow and related models/tests. - Fix scanner mail helper to return str (not tuple) - Correct scan cycle disk-space step mapping - Add optional-safety guards for scanner, pipe effector, compile model and current image - Align model typing for optional current_image and mutable compile image list - Keep ScannerEffector/tests ty-clean while preserving scan behavior - Verify with pytest tests/unit/server/test_scanning_effector.py and focused ty checks
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Compile jobs created from scan flows could miss pinning format overrides, causing downstream compilation/analysis to run with unintended pinning matrices.
Changes
Validation
Impact