fix: upgrade @grpc/grpc-js to 1.13.5 - #1621
Closed
GrahamCampbell wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Tests failing before forks don't have secrets access. |
Contributor
|
moved the commit to a branch on this repo, proceeding with that one so hopefully no further issues with merging to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades the @grpc/grpc-js pin in @gomomento/sdk from 1.13.1 to 1.13.5, which patches two high-severity denial-of-service advisories, GHSA-5375-pq7m-f5r2 and GHSA-99f4-grh7-6pcq. Since @gomomento/generated-types declares a strict peer dependency on @grpc/grpc-js, it is bumped alongside to 0.133.3, which carries the matching 1.13.5 peer requirement, keeping the install free of peer conflicts. This is the follow-up to momentohq/client-protos#343.