fix moon_config#144
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0b9b11aff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Allow parse_moon_mod post-processing to keep the documented module metadata fields readme, repository, license, keywords, and description when they are written as top-level moon.mod assignments instead of only through options(...). Normalize preferred_target to the legacy JSON preferred-target key and accept the documented compatibility array form for supported_targets, matching MoonBit module configuration docs. Add a regression test covering documented top-level moon.mod fields so these valid configurations no longer produce unexpected-key diagnostics.
myfreess
force-pushed
the
fix-moon-config
branch
from
e0b9b11 to
ee00331
Compare
Move moon config validation into dedicated validate_mbt APIs and keep post-processing focused on AST conversion. The public parse_moon_* entry points now return parser diagnostics only and leave schema validation to explicit validate_moon_* calls. Tests cover both explicit validation diagnostics and unchecked parse/post-process behavior.
myfreess
force-pushed
the
fix-moon-config
branch
from
ee00331 to
6613f8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.