You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Heads-up, Kevin — can't approve your own PR but wanted to note what I found:
jupiter-api is A+ as-is. Clean REST docs, all endpoints real, actionable curl + jq examples, correct jupiter-skills plugin block, cross-refs to moonpay-buy-crypto / moonpay-check-wallet / moonpay-swap-tokens. Verified @jup-ag/* npm packages.
jupiter-lend blocks merge. It lists SDK method signatures (deposit(mint, amount), withdraw(jlMint, amount)) but no executable examples — no imports, no initialization, no workflow an agent can follow end-to-end. As written, agents would have to write their own Node code, which violates the repo's no-code rule. Also, @jup-ag/lend-read is under a Proprietary license — worth flagging for commercial use.
Suggestion: split this into two PRs and ship jupiter-api now. Come back to jupiter-lend once there's either a CLI wrapper or concrete runnable examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #19 with signed commits and resolved conflicts. Original author: @tonyagents
Summary
Closes #19
Supersedes #41
🤖 Generated with Claude Code