Keep blank PDF pages as chunks to preserve page/chunk alignment#432
Merged
Conversation
Blank pages were dropped during ColPali rendering (since #399), so chunk numbers stopped matching source page numbers for any document containing blank pages, breaking anything that maps a chunk back to its page. Render every page: blank pages become normal chunks, and a page that fails to render now yields a white placeholder instead of being dropped. Documents where every page fails still error out as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #399, pages that render as visually blank are dropped during ColPali PDF/office rendering. That compacts the chunk list, so chunk numbers no longer match source page numbers for any document containing blank pages — anything that maps a chunk back to its page (viewers, citations) points at the wrong page.
Change
Tests
🤖 Generated with Claude Code