Infer worker types for releases, improve report formatting and diagnostics - #13
Merged
Merged
Conversation
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
unknownclassifications forrelease/token releaselog lines by inferring worker type from nearbyselectevents and make reports more informative.register.yaml) in error analysis so users can ignore them if not using the file.Description
_infer_release_worker_typeand_infer_token_release_worker_typetoscripts/log_parser.pyand use them inmatch_select_releaseto infer release types from nearby selects, treating token-release log text as not fully trustworthy.match_select_releaseto store inferred release types and use inferred types when computingtype_summarysoprefill/mixedtoken counts are more accurate.raw_token_typeand mark token releases asunknown_tokensuntil inferred.log_parser.py'sself-testflow.Failed to read YAML file config/register.yamltoSOURCE_LAYER_RULESinscripts/analyzers/errors.pyand include an informational note in the errors report when that message appears.scripts/analyzers/load_report.py, add explanatory notes about stats sampling and token-release attribution, and append an overflow indicator when many diagnoses exist.scripts/chart.pyby emitting proper separator tokens for left/right alignment.scripts/troubleshoot.pywhen determiningDEGRADEDstatus and add an explicit status definition line to the top of the full report.error_catalog.md,log_patterns.md, andreport_templates.mdto reflect the new message, log pattern details, and status definitions.Testing
log_parser.py self-testwhich includes the new token-release inference checks, and all self-test assertions passed.render_tableproduces Markdown table separators with correct alignment markers by rendering sample tables locally.Codex Task