fix: Fixed the issue of examples failing to compile under MSVC - #19
Merged
Conversation
geoyee
force-pushed
the
hotfix-msvc-examples
branch
from
May 31, 2026 13:57
886d62d to
3ea6238
Compare
Move the isatty/popen/pclose shim into a single examples/shared/platform_compat.h instead of repeating the same #ifdef _WIN32 block in four places. - Drop the trailing `#undef isatty` from the shared headers. It made including them depend on order, and an identical macro redefinition is legal, so it was never needed. - Remove the stale <unistd.h> include from the tracing example, which never used isatty. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
daavoo
force-pushed
the
hotfix-msvc-examples
branch
from
August 25, 2026 15:01
6b5868c to
2aad617
Compare
Contributor
|
thanks @geoyee ! |
daavoo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MSVC, since
<unistd.h>and its containedisattydo not exist, you can use<io.h>'s_isattyinstead.