Don't drop most of the commit date from ./mach vendor --check-for-update for some hosts - #424
Merged
tomrittervg merged 1 commit intoSep 25, 2026
Conversation
…ate for some hosts
`check_for_update` splits mach's "<revision> <timestamp>" output on every
space and keeps the second field. For a github-hosted library that second
field is the whole timestamp:
3f3735e3f39c68d33104add994bfe5d055b32e17 2026-09-09T17:56:48Z
googlesource reports commit dates with spaces in them, so there the second
field is only the weekday and the rest of the date is thrown away:
3f3735e3f39c68d33104add994bfe5d055b32e17 Wed Sep 09 17:56:48 2026
dateutil resolves a bare "Wed" against today's date, which is how
https://bugzilla.mozilla.org/show_bug.cgi?id=2070891, filed on 2026-09-10 for
a commit made on 2026-09-09, ended up titled "from 2026-09-16 00:00:00": the
next Wednesday, at midnight. libvpx, aom, irregexp and chromium-cdm are
affected the same way.
host_git.py has the same problem more quietly: `git show --format=%ci` gives
"2026-09-16 23:20:10 -0500", so there we kept the date and threw away the
time. Rather than make every host agree on one format, parse whatever the
host reports; dateutil already copes with all of them.
tnikkel
force-pushed
the
dont-drop-commit-date
branch
from
September 17, 2026 04:43
42296a5 to
c178bee
Compare
tomrittervg
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_for_updatesplits mach's " " output on everyspace and keeps the second field. For a github-hosted library that second
field is the whole timestamp:
googlesource reports commit dates with spaces in them, so there the second
field is only the weekday and the rest of the date is thrown away:
dateutil resolves a bare "Wed" against today's date, which is how
https://bugzilla.mozilla.org/show_bug.cgi?id=2070891, filed on 2026-09-10 for
a commit made on 2026-09-09, ended up titled "from 2026-09-16 00:00:00": the
next Wednesday, at midnight. libvpx, aom, irregexp and chromium-cdm are
affected the same way.
host_git.py has the same problem more quietly:
git show --format=%cigives"2026-09-16 23:20:10 -0500", so there we kept the date and threw away the
time. Rather than make every host agree on one format, parse whatever the
host reports; dateutil already copes with all of them.