fix more ruff rule exclusions; ignore BLE001 intentionally - #25462
Merged
eviljeff merged 2 commits intoSep 21, 2026
Merged
Conversation
eviljeff
marked this pull request as ready for review
September 18, 2026 14:33
eviljeff
requested review from
a team and
chrstinalin
and removed request for
a team
September 18, 2026 14:33
chrstinalin
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further follow-on work for mozilla/addons#16365
Description
Removes yet more ignored ruff rules, so we're closer to the standard list of ruff formatting/linting rules.
Context
# noqa BLE001to each occurrence. We can revisit that decision. (The fixes for BLE001 were retained in a few places, where a tighter exception was a good idea - those changes should be sense-checked by the reviewer of this patch too)Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.