Bug 2060356 - #2727
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Hardens Duo MFA verification against unverified token replay and removes unsupported recovery-code behavior.
Changes:
- Centralizes out-of-band verification checks in the MFA provider.
- Prevents provider substitution and Duo recovery-code generation.
- Adds cleanup migration, UI handling, and regression tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
userprefs.cgi |
Uses the enrolled provider and blocks Duo recovery codes. |
token.cgi |
Relies on centralized MFA event verification. |
template/en/default/account/prefs/mfa.html.tmpl |
Hides recovery-code controls for Duo. |
t/mfa-duo-verify.t |
Tests verified and unverified Duo token handling. |
Bugzilla/MFA/Duo.pm |
Enforces Duo verification proof and rejects recovery codes. |
Bugzilla/MFA.pm |
Adds provider-specific event verification. |
Bugzilla/Install/DB.pm |
Removes existing Duo recovery codes. |
Bugzilla/App/Controller/MFA/Duo.pm |
Allows the Duo callback to establish verification proof. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r+ carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2060356