Created new desktop-messaging tab under messaging/desktop for desktop…#830
Conversation
… experiment Under messaging system, added new desktop messaging that includes omc experimenter information. Also, updated
Kand1Kane
requested review from
freshstrangemusic,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
|
Here's the bug related to this PR: https://bugzilla.mozilla.org/show_bug.cgi?id=1997598 |
… experiment Under messaging system, added new desktop messaging that includes omc experimenter information. Also, updated
…rimenter-docs into desktop-messaging
|
I've also requested a review from @mimizillaa to verify the documentation changes. Even if the code looks good from your end, please hold off on approving until we have their confirmation. I'll update this PR once we get their feedback — appreciate the patience! |
|
|
||
| ## Testing the Experiment | ||
|
|
||
| When creating the JSON for treatment branches, you can verify the changes by updating the experiment to Preview Mode and by selecting **Launch to Preview**. This will provide a link that will force enroll the user into the experiment. Alternatively, you can copy paste the JSON into `about:asrouter` to preview it. |
There was a problem hiding this comment.
Coming soon: enrolling via Nimbus devtools integrations into Experimenter :) But don't update your doc with this.
|
|
||
| When creating the JSON for treatment branches, you can verify the changes by updating the experiment to Preview Mode and by selecting **Launch to Preview**. This will provide a link that will force enroll the user into the experiment. Alternatively, you can copy paste the JSON into `about:asrouter` to preview it. | ||
|
|
||
| ### Previewing in `about:asrouter` |
There was a problem hiding this comment.
Also coming soon, previewing messages with nimbus-devtools directly from experimenter :)
mimizillaa
left a comment
mimizillaa
left a comment
There was a problem hiding this comment.
LGTM, thank you! 👍 As part of the cleanup, we can also remove the OMC onboarding experimenter docs from confluence or link to these docs.
|
@jaredlockhart @freshstrangemusic could anyone re-review this PR? |
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Hi @Kand1Kane ! This is amazing thank you! I think there's a bunch of information in this page that's covered by other sections of the documentation so rather than repeating things here like creating/editing experiments, general test workflows, preview workflows etc, I think that can be left out here so we don't duplicate information in other places, and just focus here specifically on message configuration, behaviours, and relevant links to external tools and docs. But thank you so much for adding this will be super helpful for so many people 🙏
|
Hey @jaredlockhart, I've just updated and remove all duplicate information. Let me know if this looks right :) |
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Perfect this looks great to me! Tons of useful information for messaging, thank you so much for adding this! 🙏 As people start using it we'll find missing bits or changes to be made so we can keep an eye if people raise extra questions and add tweaks later but we can land this now so people can start using it. Great job 🎉 🎉 🎉
4 participants
Because
A bunch of omc-experiment documentation and desktop messaging experiment feature/information are not mentioned in the current documentation.
This commit
Fixes #831