Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves robustness of the Recorded Future “credentials search and reset” script by preventing malformed “clear” credentials (missing clear_text_value) from breaking lookups and by ensuring verification failures don’t abort the entire run.
Changes:
- Filter out
exposed_secret.type === "clear"credentials that lackdetails.clear_text_value. - Add a regression test ensuring such malformed “clear” credentials are dropped.
- Wrap per-credential password verification in a
try/catchand emit a dedicated verify-error metric.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/fxa-auth-server/scripts/recorded-future/lib.ts | Tightens filtering to require a usable clear_text_value for “clear” secrets. |
| packages/fxa-auth-server/scripts/recorded-future/lib.spec.ts | Adds regression coverage for malformed “clear” credentials. |
| packages/fxa-auth-server/scripts/recorded-future/check-and-reset.ts | Prevents a single verification error from aborting the whole run; adds verify-error metric. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+260
to
+261
| const acct = accountsByLogin[foundCredentials.subject as string]; | ||
| const passwordMatched = await verifyPassword(foundCredentials, acct); |
chenba
approved these changes
Jul 2, 2026
chenba
left a comment
chenba
left a comment
Contributor
There was a problem hiding this comment.
Nice. Definitely couldn't hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.