Conversation
Because: - The Firefox promo and recovery key/phone banners did not match the updated Figma spec (FXA-14091). This commit: - Moves the CTA below the description, left-aligned, with the optional link inline on the same row. - Normalizes banner padding to 20px and sets the CTA font size to text-sm. - Fixes banner image sizing, which was capped at 64px by a max-width / width conflict; images now render at Figma proportions and center on mobile.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the promo banner layouts in fxa-settings to better match the current Figma spec for the Firefox promo banner and the account recovery key / recovery phone banners (FXA-14091).
Changes:
- Reworks
PromotionBannerandFirefoxPromoBannerlayout to place the CTA below the description and align content per the spec. - Normalizes spacing (20px padding) and CTA typography (removes conflicting
text-base, keepstext-sm). - Adjusts promo image sizing to consistent rendered proportions and centers the image on smaller viewports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/fxa-settings/src/components/PromotionBanner/index.tsx | Updates banner flex layout, spacing, image sizing, and CTA/link placement to match the updated spec. |
| packages/fxa-settings/src/components/FirefoxPromoBanner/index.tsx | Mirrors the updated promo banner styling/layout for Firefox variants and aligns CTA styling with PromotionBanner. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+169
to
+176
| <Link | ||
| className="cta-neutral cta-base cta-base-p text-sm transition-standard" | ||
| to={`${route}${location.search ? location.search : ''}`} | ||
| data-testid={`submit_${metricsKey}`} | ||
| data-glean-id={`account_banner_${metricsKey}_submit`} | ||
| > | ||
| {ctaText} | ||
| </Link> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
PromotionBanner/index.tsxandFirefoxPromoBanner/index.tsxto match the Figma layouttext-sm(removes a conflictingtext-base)Bannercomponent untouched (semantically different, not part of the promo spec)Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-14091
Checklist
Other information
How to test:
cd packages/fxa-settings && yarn storybookComponents/PromotionBanner(recovery key + recovery phone) andComponents/FirefoxPromoBanner(all variants)