Revert Glean SQLite storage backend#3509
Draft
badboy wants to merge 4 commits into
Draft
Conversation
badboy
force-pushed
the
after-sqlite-revert
branch
2 times, most recently
from
8e2f182 to
be7c447
Compare
These are removed by reverting the SQLite merge. We need to keep them alive, because we will get them back later again when we re-merge SQLite.
badboy
force-pushed
the
after-sqlite-revert
branch
from
be7c447 to
4847411
Compare
badboy
force-pushed
the
after-sqlite-revert
branch
from
4847411 to
f442677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS PURELY A PRECAUTION! -- WE SHOULD NOT WANT TO MERGE THIS UNLESS ABSOLUTELY NECESSARY
This is in case we need to revert the SQLite changes.
This will be done using a manual rever
git revert -m1 <merge commit>.We apply a few things on top: