chore: update deps#3284
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dependency pins and aligns the codebase/tests with upstream behavior changes in Dask Distributed and pandas 3.x.
Changes:
- Bump and adjust pinned Python dependencies (notably Dask/Distributed and pandas 3).
- Update Dask client plugin registration API usage in
Analysis.run. - Update tests to accommodate pandas 3 indexing/error message changes and add Statistics schema validation in integration testing.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| requirements.in | Updates pinned dependencies, including Dask/Distributed and pandas 3. |
| jetstream/tests/test_statistics.py | Updates expected pandas error message dtype string for pandas 3. |
| jetstream/tests/integration/test_analysis_integration.py | Adjusts pandas indexing, filters export records before schema validation, and validates via mozilla_nimbus_schemas Statistics. |
| jetstream/analysis.py | Switches Dask client plugin registration to register_plugin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1305
to
+1309
| # drop NaN before validation to match BQ NDJSON extract behavior | ||
| statistics_export_data = [ | ||
| {k: v for k, v in record.items() if v == v} | ||
| for record in query_job.to_dataframe().to_dict(orient="records") | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
This appears to cover a scenario that won't happen because to_dict already converts pd.NA to None. We can revisit if the test starts failing, but I'm satisfied that this covers the expectation here.
akkomar
approved these changes
Jul 1, 2026
akkomar
left a comment
akkomar
left a comment
Member
There was a problem hiding this comment.
r+wc
#3284 (comment) might be worth fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.register_worker_plugintoclient.register_pluginstrinstead ofobject