Bug 2056550 - Run expiry checks for 2 versions ahead - #1056
Open
badboy wants to merge 1 commit into
Open
Conversation
badboy
force-pushed
the
bug-2056550-run-expiry-checks-/lpnyxyrrumzw
branch
from
July 27, 2026 14:32
204c4d7 to
f126bd6
Compare
chutten
approved these changes
Jul 28, 2026
| @@ -113,7 +113,7 @@ def get_expiring_metrics( | |||
| """ | |||
|
|
|||
| # We start warning one version ahead. | |||
Contributor
There was a problem hiding this comment.
Please also update this comment
| """ | ||
|
|
||
| next_version = str(int(latest_nightly_version) + 1) | ||
| next_version = str(int(latest_nightly_version) + 2) |
Contributor
There was a problem hiding this comment.
Please rename to... I dunno, check_version? warn_version?
Contributor
There was a problem hiding this comment.
Ah, it's called target_version below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.