Fix preprocessor cache include validation#2740
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Collaborator
|
@fallintoplace in the future, don't bother adding "Testing" in comment #0, it doesn't add value for us |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2740 +/- ##
==========================================
+ Coverage 74.56% 74.60% +0.03%
==========================================
Files 70 70
Lines 39795 39840 +45
==========================================
+ Hits 29675 29724 +49
+ Misses 10120 10116 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignore_time_macrosis enabledWhy
The old control flow returned immediately after hashing the first include in the
ignore_time_macrospath. If a later include changed, the preprocessor cache could still accept the stale result.Testing
cargo fmt --checkcargo test -q compiler::preprocessor_cache::test::test_preprocessor_cache_result_checks_all_includes_when_ignoring_time_macros --libcargo test -q compiler::preprocessor_cache --libcargo test -q --lib