Fix time macro include digest#2741
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
==========================================
+ Coverage 74.56% 74.62% +0.05%
==========================================
Files 70 70
Lines 39795 39833 +38
==========================================
+ Hits 29675 29725 +50
+ Misses 10120 10108 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__TIMESTAMP__include digest updatesWhy
The time-macro path reused a variable named
digestfromresult_matches, but that value was the cached result key, not the include file digest. Timestamp metadata updates could therefore store a digest derived from the wrong input.Testing
cargo fmt --checkcargo test -q compiler::preprocessor_cache::test::test_preprocessor_cache_timestamp_digest_uses_include_file_digest --libcargo test -q compiler::preprocessor_cache --libcargo test -q --lib