Improve toolchain cache reliability#2748
Draft
ahartmetz wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
- Coverage 74.63% 74.62% -0.02%
==========================================
Files 70 70
Lines 39898 39905 +7
==========================================
Hits 29778 29778
- Misses 10120 10127 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
it would be nice to have a test to cover this if this isn't too complex |
Collaborator
Author
It's probably doable, and maybe writing the tests will help me come up with more ideas on how this stuff can fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes do not seem to fix, at least not fully, a problem with broken toolchains that I've observed, but are probably improvements anyway.