Skip to content

Improve toolchain cache reliability#2748

Draft
ahartmetz wants to merge 3 commits into
mozilla:mainfrom
ahartmetz:toolchain_cache_reliability
Draft

Improve toolchain cache reliability#2748
ahartmetz wants to merge 3 commits into
mozilla:mainfrom
ahartmetz:toolchain_cache_reliability

Conversation

@ahartmetz

Copy link
Copy Markdown
Collaborator

These changes do not seem to fix, at least not fully, a problem with broken toolchains that I've observed, but are probably improvements anyway.

@codecov-commenter

codecov-commenter commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.62%. Comparing base (b799af2) to head (a9a728a).

Files with missing lines Patch % Lines
src/bin/sccache-dist/build.rs 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2748      +/-   ##
==========================================
- Coverage   74.63%   74.62%   -0.02%     
==========================================
  Files          70       70              
  Lines       39898    39905       +7     
==========================================
  Hits        29778    29778              
- Misses      10120    10127       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre

Copy link
Copy Markdown
Collaborator

it would be nice to have a test to cover this if this isn't too complex

@ahartmetz

Copy link
Copy Markdown
Collaborator Author

it would be nice to have a test to cover this if this isn't too complex

It's probably doable, and maybe writing the tests will help me come up with more ideas on how this stuff can fail.

@ahartmetz ahartmetz marked this pull request as draft June 20, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants