Fix ToolchainPackager cfg gate to build on ppc64le/s390x#2749
Open
cryptomilk wants to merge 1 commit into
Open
Fix ToolchainPackager cfg gate to build on ppc64le/s390x#2749cryptomilk wants to merge 1 commit into
cryptomilk wants to merge 1 commit into
Conversation
On Linux ppc64le/s390x, the blanket `impl<T: Send> ToolchainPackager for T` in pkg.rs is active (non-x86_64/aarch64 path), but the test-only PanicToolchainPackager impl in cache.rs was gated on only `target_os = "linux"`, causing a conflicting-impl error on those architectures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2749 +/- ##
=======================================
Coverage 74.63% 74.64%
=======================================
Files 70 70
Lines 39898 39898
=======================================
+ Hits 29778 29780 +2
+ Misses 10120 10118 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Build succeeded with the patch at: https://koji.fedoraproject.org/koji/taskinfo?taskID=146963651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux ppc64le/s390x, the blanket
impl<T: Send> ToolchainPackager for Tin pkg.rs is active (non-x86_64/aarch64 path), but the test-only PanicToolchainPackager impl in cache.rs was gated on onlytarget_os = "linux", causing a conflicting-impl error on those architectures.