Test: increase geminal test coverage#217
Open
kzsigmond wants to merge 13 commits into
Open
Conversation
assigning params to wfns, since default is initializing them to 0
rugwed-lokhande
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly expands and improves the test coverage for coupled cluster (CC) wavefunction classes, especially around excitation operator assignment and overlap calculations. It introduces new tests for generalized and spin-adapted AP1roGSD classes, enhances error handling and validation for excitation operator assignment, and adds comprehensive tests for overlap and its derivatives (including edge cases and parameterizations).
The most important changes are:
New and Expanded Test Suites:
AP1roGSDGeneralizedandAP1roGSDSpin, covering assignment of excitation ranks, validation of allowed excitation operators, and verifying the generation of excited determinants. [1] [2]PCCDand related AP1roGSD classes with tests for overlap calculations, edge cases, and derivatives (including finite difference checks and symmetry properties). [1] [2] [3] [4]Validation and Error Handling for Excitation Operator Assignment:
assign_exopsinAPset1roGDandAPset1GroSD, including validation of input types, value ranges, set disjointness, and occupied orbital checks. [1] [2] [3]Improvements to Excitation Operator Assignment in Implementation:
PCCDand its child classes to passindicesdirectly to the base class, ensuring correct handling of excitation operator assignment and reducing redundant calls.Test Refactoring and Organization:
Minor Additions and Imports:
ground,vir_indices). [1] [2]