Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6737 commits
Select commit Hold shift + click to select a range
6f5c124
fix(ivy): proper accounting of host vars in case of inherited Directi…
AndrewKushnir Dec 1, 2018
7d89cff
fix(ivy): Ensure ComponentFactory uses both injectors to retrieve ren…
mhevery Nov 29, 2018
2a39425
fix(ivy): temporary hack to set host styles and static classes (#27385)
kara Dec 1, 2018
8eb102a
fix(ivy): avoid counting style/class bindings in component/directive …
AndrewKushnir Dec 1, 2018
7ec05b4
fix(ivy): run initialializers in TestBed on init (#27355)
crisbeto Dec 3, 2018
06d4a0c
feat(bazel): ng-new schematics with Bazel (#27277)
Sep 14, 2018
75723d5
feat(ivy): ngtsc support for static resolution of array.slice() (#27158)
JoostK Nov 18, 2018
6552471
fix(ivy): account for `useValue: undefined` providers in module injec…
JoostK Nov 21, 2018
0cf49c8
test(ivy): run router/upgrade tests with ivy on CI (#27410)
marclaval Dec 3, 2018
7ad6b03
ci(docs-infra): manually trigger the preview server webhook (#27458)
gkalpak Dec 4, 2018
7d59880
fix(bazel): ng_package not generating UMD bundles on windows (#27200)
devversion Nov 20, 2018
20a2bae
fix(bazel): do not throw error when writing tsickle externs (#27200)
devversion Nov 21, 2018
4f93749
fix(bazel): ng_package cannot be run multiple times without clean (#2…
devversion Dec 3, 2018
d3c08e7
fix(compiler-cli): flatModuleIndex files not generated on windows wit…
devversion Dec 4, 2018
6cf3c2b
docs(ivy): fix component definition description of `inputs` (#27300)
gkalpak Dec 3, 2018
56f8c23
test(ivy): add tests for `ComponentFactory#create()` fix in #27341 (#…
gkalpak Dec 3, 2018
46bc910
test(elements): run tests with Ivy (#27300)
gkalpak Dec 3, 2018
b5ed403
fix(ivy): prevent ngtsc from synchronous compilation for in-flight re…
JoostK Nov 18, 2018
cfb67ed
feat(ivy): support styleUrls in ngtsc (#27357)
alxhub Nov 29, 2018
1597886
fix(ivy): resolve resources using TS module resolution semantics (#27…
alxhub Nov 30, 2018
8e644d9
fix(ivy): taking "interpolation" config option into account (FW-723) …
AndrewKushnir Nov 30, 2018
f0b0d64
fix(ivy): adding `projectDef` instructions to all templates where <ng…
AndrewKushnir Nov 30, 2018
b2d6f43
fix(ivy): Implement remaining methods for DebugNode (#27387)
mhevery Nov 28, 2018
c61a8b7
fix(bazel): do not throw if ts compile action does not create esm5 ou…
devversion Dec 2, 2018
e31992c
fix(ivy): missing first argument in `elementStyling` instruction insi…
AndrewKushnir Dec 2, 2018
bd864fb
feat(ivy): support WrappedValue in pipes (FW-726) (#27409)
marclaval Dec 3, 2018
7f17c70
test(ivy): add bundling test `todo_i18n` (#27420)
ocombe Dec 3, 2018
7524c99
fix(docs-infra): log the successful creation of previews (#27436)
gkalpak Dec 3, 2018
862697d
fix(ivy): return new ViewRef when detaching view (#27437)
crisbeto Dec 4, 2018
0d4149c
test(router): add test verifying guards re-run when parent path segme…
jasonaden Nov 30, 2018
89bf06c
build: update to newest ibazel (#27441)
alexeagle Dec 3, 2018
295e0f6
refactor(ivy): remove old unused test case (#27442)
mhevery Dec 3, 2018
130ae15
test(ivy): more precise TestBed failure causes for View/Content Queri…
AndrewKushnir Dec 4, 2018
145121a
test(upgrade): re-enable tests fixed in ivy (#27454)
petebacondarwin Dec 4, 2018
486f69f
test(upgrade): do not lock up browser when unit test fails (#27454)
petebacondarwin Dec 4, 2018
8973f12
fix(ivy): provided Injector should be instantiated by its factory (#2…
marclaval Dec 4, 2018
b25f06e
test(ivy): update root causes for @angular/core TestBed failures (#27…
pkozlowski-opensource Dec 4, 2018
c07afd9
test(ivy): enable ivy tests for platform-browser (#27460)
ocombe Dec 4, 2018
9062b39
test(ivy): root cause analysis for platform-browser (#27460)
ocombe Dec 4, 2018
b6dbcf9
test(ivy): add root cause on tree shakable providers test (#27465)
crisbeto Dec 4, 2018
a3ee089
fix(ivy): compiler compliance tests actualized (#27473)
AndrewKushnir Dec 5, 2018
faca8b1
test(ivy): remove symbol tests which are too big and not useful (#27446)
mhevery Dec 4, 2018
4b9948c
fix(core): More precise return type for `InjectableDecorator` (#27360)
mhevery Nov 29, 2018
f52600e
test(ivy): add ability to find already passing tests (#27449)
mhevery Dec 4, 2018
ccc77ca
fix(router): change processing url tree children condition (#26243)
miginmrs Oct 4, 2018
20cef50
fix(router): process empty path segment when preceding a named outlet…
miginmrs Oct 5, 2018
1279a50
feat(ivy): add ng-reflect debug text for containers (#27350)
ocombe Nov 29, 2018
2bc3986
feat(ivy): support inputs & outputs with aliases in component decorat…
ocombe Nov 30, 2018
cd85832
feat(ivy): Forward refs now supported (#27439)
benlesh Dec 3, 2018
d70a7f3
feat(router): add pathParamsOrQueryParamsChange mode for runGuardsAnd…
jasonaden Dec 4, 2018
345bdd3
fix(ivy): generate empty ngfactory files if needed (#27470)
alxhub Dec 4, 2018
0d8ab32
fix(ivy): add missing directoryExists() method to shim CompilerHost (…
alxhub Dec 5, 2018
8f42570
test(ivy): enable //packages/bazel/test/ngc-wrapped/... tests for Ivy…
alxhub Dec 5, 2018
68074df
build(bazel): replace yarn_install(name = "npm") with @npm local_repo…
gregmagolan Dec 5, 2018
2643350
build: to fsevents@2.0.1 (#27469)
IgorMinar Dec 5, 2018
821fecb
test(ivy): update root causes for @angular/core TestBed failures (#27…
pkozlowski-opensource Dec 5, 2018
24ebdbd
ci: test ts-api-guardian on windows (#27205)
filipesilva Nov 15, 2018
445f789
build: error when files specified in payload size limits are missing …
gkalpak Nov 23, 2018
33977a2
refactor(docs-infra): move minified `lunr` script to the `generated` …
gkalpak Nov 23, 2018
b2f73dd
fix(docs-infra): do not create an anchor for the `file-not-found` hea…
gkalpak Nov 23, 2018
dca1535
fix(docs-infra): always fetch Roboto font (#27250)
gkalpak Nov 26, 2018
2adf03e
fix(docs-infra): inline SVG icons used in page load sensitive UI (#27…
gkalpak Nov 26, 2018
27b196f
fix(docs-infra): remove hard-coded color from inlined SVG icons (#27250)
gkalpak Nov 27, 2018
af952ca
fix(docs-infra): ensure material icons are cached for offline access …
gkalpak Nov 26, 2018
271fcb0
fix(docs-infra): correctly cache footer image by the SW (#27250)
gkalpak Nov 26, 2018
fa0c65e
build(docs-infra): remove dependency on FontAwesome (#27250)
gkalpak Nov 27, 2018
dfdc2ad
fix(docs-infra): fix sidenav positioning when notification is shown (…
gkalpak Nov 27, 2018
6abbaae
fix(docs-infra): do not use an Angular element in hard-coded `FETCH_E…
gkalpak Nov 27, 2018
4b5cd72
refactor(docs-infra): remove unused custom element (#27250)
gkalpak Nov 27, 2018
8973dd5
build(docs-infra): upgrade cli command docs sources to 1c01b91c6 (#27…
gkalpak Dec 4, 2018
b82f62a
test(ivy): enable ivy tests for platform-browser/animations (#27478)
ocombe Dec 5, 2018
dfdaaf6
fix(ivy): deduplicate directives in component scopes (#27462)
alxhub Dec 4, 2018
cdf5cac
build: add kara to more approval lists (#27493)
kara Dec 5, 2018
d553ec2
fix(ivy): generate correct moduleNames for factories and summaries (#…
alxhub Dec 5, 2018
276bdd1
fix(ivy): move the generation of ɵNonEmptyModule to shim construction…
alxhub Dec 5, 2018
0ae8c08
build(ivy): expect factories and summaries in Ivy mode (#27483)
alxhub Dec 5, 2018
f514ac3
test(ivy): enable //packages/router/test/aot_ngsummary_test in Ivy mo…
alxhub Dec 5, 2018
a315ded
fix(ivy): fix fixmeIvy invocations in "platform-browser" tests (#27498)
AndrewKushnir Dec 6, 2018
55e24d2
ci: don't run router tests on travis (#27386)
IgorMinar Dec 1, 2018
4f81a7c
test(common): run @angular/common/http/testing tests under bazel (#27…
IgorMinar Dec 1, 2018
95f8b63
test(service-worker): run the remaining service-worker tests under ba…
IgorMinar Dec 1, 2018
21f6daf
test: correct bazel visibility for @angular/private/testing (#27386)
IgorMinar Dec 1, 2018
dacf58e
docs: remove obsolete packages/examples/web_workers/ts/.gitkeep (#27386)
IgorMinar Dec 1, 2018
2ccf5c4
ci: remove validate-commit-message tests from travis (#27386)
IgorMinar Dec 1, 2018
917a788
test(benchpress): make most of the tests run under bazel (#27386)
IgorMinar Dec 1, 2018
8a63f6e
ci: don't run node unit tests on travis (#27386)
IgorMinar Dec 1, 2018
6740d0d
build: remove obsolete gulp build task (#27386)
IgorMinar Dec 1, 2018
4f61832
Revert "fix(router): process empty path segment when preceding a name…
IgorMinar Dec 6, 2018
091a504
Revert "fix(router): change processing url tree children condition (#…
IgorMinar Dec 6, 2018
ca1c430
fix(compiler-cli): ngtsc shim files not being generated on case-insen…
devversion Dec 4, 2018
160cace
test(ivy): fix query compliance spec (#27501)
kara Dec 6, 2018
7c52d10
Revert "ci: test ts-api-guardian on windows (#27205)"
IgorMinar Dec 6, 2018
d63d53f
ci: test ts-api-guardian on windows (#27205)
filipesilva Nov 15, 2018
7f221d8
build: introduce remote bazel caching (#27358)
mgechev Nov 28, 2018
159ab1c
fix(ivy): ngtsc should include generic types on injectable definition…
JoostK Nov 10, 2018
8e9858f
fix(ivy): align NgModuleRef implementation between Ivy and ViewEngine…
marclaval Dec 5, 2018
21d13dd
fix(ivy): Added missing getHostElement to export (#27488)
SanderElias Dec 6, 2018
4da739a
fix(bazel): Respect existing angular installation (#27495)
kyliau Dec 5, 2018
c71d7b5
fix(ivy): setting up animation properties correctly (FW-643) (#27496)
AndrewKushnir Dec 5, 2018
cad6714
fix(ivy): "select" attribute on <ng-content> should not be case-sensi…
AndrewKushnir Dec 6, 2018
8fa7e93
test(ivy): enable router tests with pending timers (FW-768) (#27509)
marclaval Dec 6, 2018
913563a
test(ivy): finish root cause analysis for @angular/core TestBed faili…
pkozlowski-opensource Dec 6, 2018
f013c57
test(router): correct a wrong test (FW-766) (#27511)
marclaval Dec 6, 2018
7a6eb9d
release: cut the v7.2.0-beta.1 release
IgorMinar Dec 6, 2018
6bd28e6
docs: release notes for the v7.1.2 release
IgorMinar Dec 7, 2018
352c582
refactor(ivy): allow for shim generators not based on existing files …
alxhub Dec 5, 2018
aa48810
feat(ivy): generate flat module index files (#27497)
alxhub Dec 6, 2018
5657126
test(ivy): run browser-specific @angular/core tests on CI (#27545)
pkozlowski-opensource Dec 7, 2018
6316051
build(docs-infra): upgrade cli command docs sources to 5eef7122c (#27…
gkalpak Dec 7, 2018
dcb44e6
fix(ivy): generate proper event listener names for animation events (…
AndrewKushnir Dec 6, 2018
f6a67c9
ci: update ngbot config to add merge linked labels (#27512)
ocombe Dec 6, 2018
cab5927
ci: use buildifier binary release (#27489)
alexeagle Dec 5, 2018
15ca1bb
style: run latest buildifier binary (#27489)
alexeagle Dec 6, 2018
055dc2d
docs: file new issue needs to have opener choose type from template (…
Dec 2, 2018
2a35471
test(upgrade): add diagnosis to failing ivy tests (#27542)
petebacondarwin Dec 7, 2018
b0c7561
fix(forms): typed argument for FormBuilder group (#26985)
cexbrayat Nov 7, 2018
f034114
fix(bazel): tsickle dependency not working with typescript 3.1.x (#27…
devversion Dec 2, 2018
84ad0cc
build: update source-map-support to get rid of Node's DeprecationWarn…
IgorMinar Dec 7, 2018
255e672
fix(ivy): define correct SVG namespace (FW-757) (#27529)
AndrewKushnir Dec 7, 2018
44dd764
build: update to Bazel 0.20 (#27394)
alexeagle Dec 2, 2018
9e7a8f6
refactor(ivy): dedup render3 NodeInjector (#27541)
ocombe Dec 7, 2018
54e4bdb
docs: remove AngularDart from the version picker (#27550)
IgorMinar Dec 7, 2018
2182be4
test(ivy): enable more of @angular/core tests on node and in a browse…
pkozlowski-opensource Dec 10, 2018
f5c0b30
test: remove extranious fixme from packages/bazel/test/ngc-wrapped (#…
IgorMinar Dec 10, 2018
16d26e5
docs: add webucator to resources (#26895)
isunkes Nov 1, 2018
05cdfb9
fix(ivy): make ViewRef.detectChanges work with embedded views (FW-749…
AndrewKushnir Dec 6, 2018
bf57e9d
build: update rules_typescript (#27586)
alexeagle Dec 10, 2018
50687e1
build: fix type-check errors introduced during rules_ts 0.21 (#27586)
alexeagle Dec 10, 2018
30a3b49
fix(bazel): Read latest versions from latest-versions.ts & use semver…
kyliau Dec 6, 2018
3290fc3
fix(bazel): fix TS errors in the `schematics/bazel-workspace` files (…
petebacondarwin Dec 11, 2018
fb6a31c
build: exclude ivy commit messages from the release notes (#27532)
IgorMinar Dec 6, 2018
3cb6dad
docs: update npm scripts to support angular 7 (#27334)
mjawulski Dec 6, 2018
ceb14de
fix(ivy): proper slot allocation for pure functions in `hostBindings`…
AndrewKushnir Dec 10, 2018
452668b
fix(ivy): host bindings should work if input has same name (#27589)
kara Dec 10, 2018
6980631
test(ivy): update root causes for @angular/core TestBed failures (#27…
pkozlowski-opensource Dec 11, 2018
053b43d
fix(ivy): update new host binding test with instruction change (#27605)
kara Dec 11, 2018
098a787
docs: release notes for the v7.1.3 release
alxhub Dec 11, 2018
b69ec48
release: cut the v7.2.0-beta.2 release
alxhub Dec 11, 2018
dc1ed3c
docs: fix ngModel typo in form validation guide (#27574)
lboullo0 Dec 10, 2018
93820b4
build: bump @bazel/ibazel to 0.9.0 (#27601)
IgorMinar Dec 11, 2018
cabf1c7
docs: update SAVED_REPLIES and CONTRIBUTING with new issue templates …
IgorMinar Dec 11, 2018
042463f
build(bazel): fix postinstall-patches.js script run during yarn posti…
gregmagolan Dec 12, 2018
fc6dc78
fix(docs-infra): fix top menu item clickable area (#27620)
macjohnny Dec 12, 2018
28ceca0
test(ivy): update root causes for @angular/core TestBed failures (#27…
pkozlowski-opensource Dec 12, 2018
2380b97
build: update to tsickle 0.33.1 (#27612)
gregmagolan Dec 12, 2018
9c7fb0d
docs: add Zenika trainings in resources.json (#27216)
EmmanuelDemey Nov 21, 2018
37c05bd
fix(ivy): avoid destroy renderer method invocation for child views (#…
AndrewKushnir Dec 11, 2018
7fabe44
fix(ivy): add support for optional nullable injection tokens (#27552)
IgorMinar Dec 7, 2018
5256a91
build: update to latest karma-sauce-launcher version (#27634)
devversion Dec 12, 2018
f00af3e
ci: exclude unnedeed files and directories from angular-robot g3sync …
IgorMinar Dec 13, 2018
e318081
ci: remove packages/bazel from compiler-cli group (#27641)
IgorMinar Dec 13, 2018
1cc08b4
fix(bazel): fix major/minor semver check between @angular/bazel npm p…
gregmagolan Dec 12, 2018
e3a2ca5
fix(docs-infra): fix top menu item clickable area (#27633)
macjohnny Dec 12, 2018
e5c10c3
docs: remove labs breaking changes from changelog (#27628)
StephenFluin Dec 12, 2018
ffe1b4d
build: disable postinstall-patch.js log output (#27619)
IgorMinar Dec 12, 2018
8313ffc
fix(bazel): Load http_archive and rules_nodejs dependencies (#27609)
kyliau Dec 12, 2018
e269274
build: ts-api-guardian tsconfig warning with bazel (#27583)
devversion Dec 10, 2018
6b96931
fix(ivy): enable flat module index production in Bazel (#27655)
alxhub Dec 13, 2018
0397e08
test(ivy): update test status for cases modified in ivy (#27652)
pkozlowski-opensource Dec 13, 2018
10c7b89
test(ivy): update root causes for @angular/core TestBed failures (#27…
pkozlowski-opensource Dec 13, 2018
3970d00
test(ivy): remove state fixme from packages/compiler-cli/test:ngtools…
IgorMinar Dec 13, 2018
44dfa60
fix(bazel): ng_package writes unrelevant definitions to bazel out (#2…
devversion Dec 6, 2018
fdf3998
fix(ivy): do not use MSG_ prefix for i18nPostprocess invocation (FW-7…
AndrewKushnir Dec 4, 2018
ad26cd6
fix(router): ensure URL is updated after second redirect with UrlUpda…
jasonaden Dec 6, 2018
5902a46
build(docs-infra): upgrade cli command docs sources to 02d2ec250 (#27…
gkalpak Dec 14, 2018
3680aef
test(bazel): integration test for ng new with Bazel (#27659)
kyliau Dec 12, 2018
31006f7
build: disable failing optional travis jobs (#27657)
devversion Dec 13, 2018
c6ae729
build: re-enable saucelabs non-verbose logging (#27657)
devversion Dec 13, 2018
cba92db
test(ivy): remove stale fixmes from //packages/platform-server/test …
IgorMinar Dec 13, 2018
8f8c5ba
test(ivy): improve fixme message in //packages/platform-webworker/tes…
IgorMinar Dec 13, 2018
d528e30
test(ivy): update fixmes in packages/core/test/linker/jit_summaries_i…
IgorMinar Dec 13, 2018
d32939d
build: restrict visibility of npm_package targets (#27611)
alexeagle Dec 12, 2018
5d34657
fix(ivy): attempting to remove detached view on destroy (#27585)
crisbeto Dec 11, 2018
7fae911
docs(common): Fix typo in KeyValuePipe docs (#27580)
cooljeffro Dec 10, 2018
a8ebc83
fix(ivy): support complex type nodes in ModuleWithProviders (#27562)
JoostK Dec 9, 2018
a954345
fix(ivy): prevent invalid forward references in setClassMetadata call…
JoostK Dec 9, 2018
d0d351c
docs(common): update currencyPipe default digitsInfo values (#27417)
Dec 3, 2018
650c5a0
Revert "fix(router): ensure URL is updated after second redirect with…
mhevery Dec 14, 2018
522919a
fix(bazel): emit full node stack traces when Angular compilation cras…
IgorMinar Dec 14, 2018
0b78f54
docs(router): typo in state documentation (#27671)
cexbrayat Dec 14, 2018
f9545d1
docs: adding ngAtlanta 2019 (#27522)
zackarychapple Dec 14, 2018
b39efdd
fix(common): KeyValuePipe should return empty array for empty objects…
Airblader Nov 24, 2018
023bd31
fix(ivy): ngcc should not emit TypeScript syntax (#27051)
JoostK Dec 10, 2018
df123e0
fix(animations): mark actual descendant node as disabled (#26180)
JoostK Sep 29, 2018
f1c9d6a
fix(animations): do not truncate decimals for delay (#24455)
vladimir-barsuchenko Jun 12, 2018
b00aeef
fix(ivy): properly destroy views created by ComponentFactory (#27676)
pkozlowski-opensource Dec 14, 2018
4df82bd
test(ivy): don't run`ViewEngine` tests for ivy (#27645)
ocombe Dec 13, 2018
f4a797d
fix(ivy): prevent ngcc from inadvertently dropping Ivy definitions (#…
JoostK Nov 18, 2018
7dab458
docs(common): fix documentation for getLocaleCurrencyName (#27087)
rjabbarov Nov 14, 2018
f8096d4
docs(animations): rename animateChild() to animate() (#26184)
cyraid Sep 30, 2018
ea10a3a
test(ivy): enable all test for @angular/common (#27700)
pkozlowski-opensource Dec 17, 2018
dfbf6d7
fix(ivy): provide an ability to match <ng-template> tags (#27636)
AndrewKushnir Dec 12, 2018
a726338
docs: Add Smart UI to UI Components section in resources (#27515)
bmarkov Dec 6, 2018
1160025
fix(ivy): prevent DCE of __POST_R3__ symbols (#27438)
JoostK Dec 3, 2018
84084b1
fix(ivy): make exported pipes available in module scope (#27438)
JoostK Dec 3, 2018
52544ff
fix(ivy): ngcc generates setClassMetadata calls for ES5 bundles (#27438)
JoostK Dec 4, 2018
4376ec2
perf(ivy): let ngcc first check marker file before assembling bundle …
JoostK Dec 4, 2018
b5b229d
test(ivy): synchronize cli-hello-world-ivy with cli-hello-world integ…
JoostK Dec 3, 2018
44ec66d
test(ivy): enable running cli-hello-world-ivy integration test suite …
JoostK Dec 3, 2018
94f17e9
docs: remove misplaced code in Universal guide (#26865)
emilio-martinez Oct 31, 2018
d132bae
test(ivy): add more test for content projection with ngIf / ngFor (#2…
pkozlowski-opensource Dec 17, 2018
e94975d
fix(ivy): check semantics of NgModule for consistency (#27604)
mhevery Dec 11, 2018
3444aee
test(upgrade): update test failure cause descriptions (#27660)
petebacondarwin Dec 14, 2018
c986d3d
fix(upgrade): upgrade Directive facade should not return different in…
petebacondarwin Dec 13, 2018
85866de
fix(bazel): Set module_name and enable ng test (#27715)
Dec 17, 2018
87d7b74
build: improve error message for upgrade test helper (#27706)
devversion Dec 17, 2018
a433baf
docs(forms): update API reference for validator directives (#26926)
brandonroberts Nov 1, 2018
8042140
test(ivy): enable more @angular/core tests (#27654)
marclaval Dec 13, 2018
062c7af
test(ivy): replace resolved issue in compiler-cli test with new root …
kara Dec 17, 2018
4c1cd1b
feat(ivy): support context discovery for containers & ICU expressions…
ocombe Dec 17, 2018
9bfe428
fix(ivy): call `hostBindings` function with proper element index (#27…
AndrewKushnir Dec 15, 2018
4bf8d64
fix(ivy): restore `fixmeIvy` imports for Router-related tests (#27720)
AndrewKushnir Dec 18, 2018
e98c57a
refactor(core): rename spec file to match case of src file
mhevery Dec 18, 2018
f57916c
fix(bazel): devserver entry_module should have underscore name (#27719)
kyliau Dec 18, 2018
d766ad0
build: update gulp-clang-format dependency (#27712)
devversion Dec 17, 2018
1b6c4e7
build: load angular.js minified output in upgrade tests (#27711)
devversion Dec 17, 2018
8fdd702
docs: Fixed typo (#27669)
sharathgeorgem Dec 14, 2018
8d0a3ce
build: use https link to editorconfig.org in .editorconfig (#27664)
coliff Dec 14, 2018
4774a1a
docs(bazel): Update VSCode config (#27733)
benlesh Dec 18, 2018
1c93afe
fix(ivy): fix property names of ngOnChanges (#27714)
mhevery Dec 17, 2018
b04bc5d
test(ivy): re-enable passing upgrade tests (#27736)
kara Dec 18, 2018
17e702b
feat: add support for typescript 3.2 (#27536)
IgorMinar Dec 7, 2018
2c9b6c0
fix(compiler-cli): create LiteralLikeNode for String and Number liter…
Dec 14, 2018
cdfe8f4
fix(docs-infra): workaround for broken 'import as' (#27536)
IgorMinar Dec 17, 2018
999bd5b
build(docs-infra): update dgeni and dgeni-packages to latest (#27536)
petebacondarwin Dec 17, 2018
8684fb5
build(docs-infra): disable cli.warnings.typescriptMismatch warnings (…
IgorMinar Dec 18, 2018
69198ba
build(docs-infra): turn on disableTypeScriptVersionCheck in angularCo…
IgorMinar Dec 18, 2018
7901cd8
fix(ivy): add missing AttributeMarker export (#27485)
mhevery Dec 5, 2018
12c3176
feat(router): add predicate function mode for runGuardsAndResolvers …
jasonaden Dec 14, 2018
24fa0b7
docs: release notes for the v7.1.4 release
mhevery Dec 18, 2018
f48a00f
release: cut the v7.2.0-rc.0 release
mhevery Dec 19, 2018
a20b2f7
fix(ivy): process creation mode deeply before running update mode (#2…
kara Dec 19, 2018
e8f7241
build: fix our copy of Array#find typing (#27742)
alexeagle Dec 19, 2018
8f8572f
fix(ivy): @Host should behave as in View Engine (#27646)
marclaval Dec 13, 2018
0604527
Revert "build: update gulp-clang-format dependency (#27712)" (#27759)
devversion Dec 19, 2018
3ab25ab
refactor: fix broken linting rules due to revert
matsko Dec 19, 2018
b08f3ac
test(bazel): Make sure CLI project created with Bazel works with orig…
kyliau Dec 18, 2018
99d0e27
test(ivy): update root cause for core test (#27768)
kara Dec 19, 2018
cfb8c17
feat(ivy): ngcc - map functions as well as classes from source to typ…
petebacondarwin Nov 29, 2018
f2a1c66
feat(ivy): ngcc - add typings to `ModuleWithProviders` functions (#27…
petebacondarwin Dec 7, 2018
4b70a4e
feat(ivy): support NgModule metadata from calls that do not return Mo…
petebacondarwin Dec 11, 2018
a833b98
fix(ivy): change detection strategy not being passed to compiler (#27…
crisbeto Dec 20, 2018
a0585c9
fix(ivy): correct content projection with nested templates (#27755)
pkozlowski-opensource Dec 19, 2018
880e8a5
refactor: fix broken formatting
matsko Dec 20, 2018
07ada7f
fix(router): ensure URL is updated after second redirect with UrlUpda…
jasonaden Dec 6, 2018
8a7498e
refactor(upgrade): simplify special handling of ngUpgradeLite in `dow…
gkalpak Nov 20, 2018
326b464
fix(upgrade): correctly handle nested downgraded components with `dow…
gkalpak Nov 20, 2018
bc0ee01
fix(upgrade): allow nesting components from different downgraded modu…
gkalpak Nov 20, 2018
077a5fb
test(upgrade): test injector tree traversal for downgraded components…
gkalpak Nov 20, 2018
50a91ba
docs(upgrade): add gotchas/tips/example for multiple downgraded modul…
gkalpak Dec 14, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
4 changes: 4 additions & 0 deletions .bazelignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
node_modules
dist
aio/node_modules
aio/tools/examples/shared/node_modules
101 changes: 101 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
# Load any settings specific to the current user
try-import .bazelrc.user
################################
# Settings for Angular team members only
################################
# To enable this feature check the "Remote caching" section in docs/BAZEL.md.
build:angular-team --remote_http_cache=https://storage.googleapis.com/angular-team-cache

###############################
# Typescript / Angular / Sass #
###############################

# Make compilation fast, by keeping a few copies of the compilers
# running as daemons, and cache SourceFile AST's to reduce parse time.
build --strategy=TypeScriptCompile=worker
build --strategy=AngularTemplateCompile=worker

# Enable debugging tests with --config=debug
test:debug --test_arg=--node_options=--inspect-brk --test_output=streamed --test_strategy=exclusive --test_timeout=9999 --nocache_test_results

###############################
# Filesystem interactions #
###############################

# Don't create symlinks like bazel-out in the project.
# These cause VSCode to traverse a massive tree, opening file handles and
# eventually a surprising failure with auto-discovery of the C++ toolchain in
# MacOS High Sierra.
# See https://github.com/bazelbuild/bazel/issues/4603
build --symlink_prefix=/

# Performance: avoid stat'ing input files
build --watchfs

# Turn off legacy external runfiles
run --nolegacy_external_runfiles
test --nolegacy_external_runfiles

###############################
# Release support #
# Turn on these settings with #
# --config=release #
###############################

# Releases should always be stamped with version control info
build:release --workspace_status_command=./tools/bazel_stamp_vars.sh

###############################
# Output #
###############################

# A more useful default output mode for bazel query
# Prints eg. "ng_module rule //foo:bar" rather than just "//foo:bar"
query --output=label_kind

# By default, failing tests don't print any output, it goes to the log file
test --test_output=errors

# Show which actions are run under workers,
# and print all the actions running in parallel.
# Helps to demonstrate that bazel uses all the cores on the machine.
build --experimental_ui
test --experimental_ui

################################
# Settings for CircleCI #
################################

# Bazel flags for CircleCI are in /.circleci/bazel.rc

################################
# Temporary Settings for Ivy #
################################
# to determine if the compiler used should be Ivy or ViewEngine one can use `--define=compile=aot` on
# any bazel target. This is a temporary flag until codebase is permanently switched to Ivy.
build --define=compile=legacy

###############################
# Remote Build Execution support
# Turn on these settings with
# --config=remote
###############################

# Load default settings for Remote Build Execution
import %workspace%/third_party/github.com/bazelbuild/bazel-toolchains/bazelrc/bazel-0.20.0.bazelrc

# Increase the default number of jobs by 50% because our build has lots of
# parallelism
build:remote --jobs=150

# Point to our custom execution platform; see tools/BUILD.bazel
build:remote --extra_execution_platforms=//tools:rbe_ubuntu1604-angular
build:remote --host_platform=//tools:rbe_ubuntu1604-angular
build:remote --platforms=//tools:rbe_ubuntu1604-angular

# Remote instance.
build:remote --remote_instance_name=projects/internal-200822/instances/default_instance

# Do not accept remote cache.
# We need to understand the security risks of using prior build artifacts.
build:remote --remote_accept_cached=false
42 changes: 42 additions & 0 deletions .buildkite/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Heavily based on https://github.com/StefanScherer/dockerfiles-windows/ images.
# Combines the node windowsservercore image with the Bazel Prerequisites (https://docs.bazel.build/versions/master/install-windows.html).
# msys install taken from https://github.com/StefanScherer/dockerfiles-windows/issues/30
# VS redist install taken from https://github.com/StefanScherer/dockerfiles-windows/blob/master/apache/Dockerfile
# The nanoserver image won't work because MSYS2 does not run in it https://github.com/Alexpux/MSYS2-packages/issues/1493

# Before building this image, you must locally build node-windows:10.13.0-windowsservercore-1803.
# Clone https://github.com/StefanScherer/dockerfiles-windows/commit/4ce7101a766b9b880ac262479dd9126b64d656cf and build using
# docker build -t node-windows:10.13.0-windowsservercore-1803 --build-arg core=microsoft/windowsservercore:1803 --build-arg target=microsoft/windowsservercore:1803 .
FROM node-windows:10.13.0-windowsservercore-1803

SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]

# Install 7zip to extract msys2
RUN Invoke-WebRequest -UseBasicParsing 'https://www.7-zip.org/a/7z1805-x64.exe' -OutFile 7z.exe
# For some reason the last letter in the destination directory is lost. So '/D=C:\\7zip0' will extract to '/D=C:\\7zip'.
RUN Start-Process -FilePath 'C:\\7z.exe' -ArgumentList '/S', '/D=C:\\7zip0' -NoNewWindow -Wait

# Extract msys2
RUN Invoke-WebRequest -UseBasicParsing 'http://repo.msys2.org/distrib/x86_64/msys2-base-x86_64-20180531.tar.xz' -OutFile msys2.tar.xz
RUN Start-Process -FilePath 'C:\\7zip\\7z' -ArgumentList 'e', 'msys2.tar.xz' -Wait
RUN Start-Process -FilePath 'C:\\7zip\\7z' -ArgumentList 'x', 'msys2.tar', '-oC:\\' -Wait
RUN Remove-Item msys2.tar.xz
RUN Remove-Item msys2.tar
RUN Remove-Item 7z.exe
RUN Remove-Item -Recurse 7zip

# Add MSYS2 to PATH, and set BAZEL_SH
RUN [Environment]::SetEnvironmentVariable('Path', $env:Path + ';C:\msys64\usr\bin', [System.EnvironmentVariableTarget]::Machine)
RUN [Environment]::SetEnvironmentVariable('BAZEL_SH', 'C:\msys64\usr\bin\bash.exe', [System.EnvironmentVariableTarget]::Machine)

# Install Microsoft Visual C++ Redistributable for Visual Studio 2015
RUN Invoke-WebRequest -UseBasicParsing 'https://download.microsoft.com/download/9/3/F/93FCF1E7-E6A4-478B-96E7-D4B285925B00/vc_redist.x64.exe' -OutFile vc_redist.x64.exe
RUN Start-Process 'c:\\vc_redist.x64.exe' -ArgumentList '/Install', '/Passive', '/NoRestart' -NoNewWindow -Wait
RUN Remove-Item vc_redist.x64.exe

# Add a fix for https://github.com/docker/for-win/issues/2920 as entry point to the container.
SHELL ["cmd", "/c"]
COPY "fix-msys64.cmd" "C:\\fix-msys64.cmd"
ENTRYPOINT cmd /C C:\\fix-msys64.cmd && cmd /c

CMD ["cmd.exe"]
96 changes: 96 additions & 0 deletions .buildkite/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
# BuildKite configuration

This folder contains configuration for the [BuildKite](https://buildkite.com) based CI checks for
this repository.

BuildKite is a CI provider that provides build coordination and reports while we provide the
infrastructure.

CI runs are triggered by new PRs and will show up on the GitHub checks interface, along with the
other current CI solutions.

Currently it is only used for tests on Windows platforms.


## The build pipeline

BuildKite uses a pipeline for each repository. The `pipeline.yml` file defines pipeline
[build steps](https://buildkite.com/docs/pipelines/defining-steps) for this repository.

Run results can be seen in the GitHub checks interface and in the
[pipeline dashboard](https://buildkite.com/angular/angular).

Although most configuration is done via `pipeline.yml`, some options are only available
in the online [pipeline settings](https://buildkite.com/angular/angular/settings).


## Infrastructure

BuildKite does not provide the host machines where the builds runs, providing instead the
[BuildKite Agent](https://buildkite.com/docs/agent/v3) that should be run our own infrastructure.


### Agents

This agent polls the BuildKite API for builds, runs them, and reports back the results.
Agents are the unit of concurrency: each agent can run one build at any given time.
Adding agents allows more builds to be ran at the same time.

Individual agents can have tags, and pipeline steps can target only agents with certain tags via the
`agents` field in `pipeline.yml`.
For example: agents on Windows machines are tagged as `windows`, and the Windows specific build
steps list `windows: true` in their `agents` field.

You can see the current agent pool, along with their tags, in the
[agents list](https://buildkite.com/organizations/angular/agents).


### Our host machines

We use [Google Cloud](https://cloud.google.com/) as our cloud provider, under the
[Angular project](https://console.cloud.google.com/home/dashboard?project=internal-200822).
To access this project you need need to be logged in with a Google account that's a member of
team@angular.io.
For googlers this may be your google.com account, for others it is an angular.io account.

In this project we have a number of Windows VMs running, each of them with several agents.
The `provision-windows-buildkite.ps1` file contains instructions on how to create new host VMs that
are fully configured to run the BuildKite agents as services.

Our pipeline uses [docker-buildkite-plugin](https://github.com/buildkite-plugins/docker-buildkite-plugin)
to run build steps inside docker containers.
This way we achieve isolation and hermeticity.

The `Dockerfile` file describes a custom Docker image that includes NodeJs, Yarn, and the Bazel
pre-requisites on Windows.

To upload a new version of the docker image, follow any build instructions in `Dockerfile` and then
run `docker build -t angular/node-bazel-windows:NEW_VERSION`, followed by
`docker push angular/node-bazel-windows:NEW_VERSION`.
After being pushed it should be available online, and you can use the new version in `pipeline.yml`.


## Caretaker

BuildKite status can be found at https://www.buildkitestatus.com/.

Issues related to the BuildKite setup should be escalated to the Tools Team via the current
caretaker, followed by Alex Eagle and Filipe Silva.

Support requests should be submitted via email to support@buildkite.com and cc Igor, Misko, Alex,
Jeremy and Manu


## Rollout strategy

At the moment our BuildKite CI uses 1 host VM running 4 agents, thus being capable of 4 concurrent
builds.
The only test running is `bazel test //tools/ts-api-guardian:all`, and the PR check is not
mandatory.

In the future we should add cache support to speed up the initial `yarn` install, and also Bazel
remote caching to speed up Bazel builds.

After the current setup is verified as stable and reliable the GitHub PR check can become mandatory.

The tests ran should also be expanded to cover most, if not all, of the Bazel tests.
6 changes: 6 additions & 0 deletions .buildkite/fix-msys64.cmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
@echo off
REM Fix for https://github.com/docker/for-win/issues/2920
REM echo "Fixing msys64 folder..."
REM Touch all .dll files inside C:\msys64\
forfiles /p C:\msys64\ /s /m *.dll /c "cmd /c Copy /B @path+,, >NUL"
REM echo "Fixed msys64 folder."
10 changes: 10 additions & 0 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
steps:
- label: windows-test
commands:
- "yarn install --frozen-lockfile --non-interactive --network-timeout 100000"
- "yarn bazel test //tools/ts-api-guardian:all --noshow_progress"
plugins:
- docker#v2.1.0:
image: "filipesilva/node-bazel-windows:0.0.2"
agents:
windows: true
92 changes: 92 additions & 0 deletions .buildkite/provision-windows-buildkite.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
# PowerShell script to provision a Windows Server with BuildKite
# This script follows https://buildkite.com/docs/agent/v3/windows.

# Instructions

# VM creation:
# In Google Cloud Platform, create a Compute Engine instance.
# We recommend machine type n1-highcpu-16 (16 vCPUs, 14.4 GB memory).
# Use a windows boot disk with container support such as
# "Windows Server version 1803 Datacenter Core for Containers".
# Give it a name, then click "Create".

# VM setup:
# In the Compute Engine menu, select "VM Instances". Click on the VM name you chose before.
# Click "Set Windows Password" to choose a username and password.
# Click RDP to open a remote desktop via browser, using the username and password.
# In the Windows command prompt start an elevated powershell by inputing
# "powershell -Command "Start-Process PowerShell -Verb RunAs" followed by Enter.
# Download and execute this script from GitHub, passing the token (mandatory), tags (optional)
# and number of agents (optional) as args:
# ```
# Invoke-WebRequest -Uri https://raw.githubusercontent.com/angular/angular/master/.buildkite/provision-windows-buildkite.ps1 -OutFile provision.ps1
# .\provision.ps1 -token "MY_TOKEN" -tags "windows=true,another_tag=true" -agents 4
# ```
# The VM should restart and be fully configured.

# Creating extra VMs
# You can create an image of the current VM by following the instructions below.
# https://cloud.google.com/compute/docs/instances/windows/creating-windows-os-image
# Then create a new VM and choose "Custom images".


# Script proper.

# Get the token and tags from arguments.
param (
[Parameter(Mandatory=$true)][string]$token,
[string]$tags = ""
[Int]$agents = 1
)

# Allow HTTPS
[Net.ServicePointManager]::SecurityProtocol = "tls12, tls11, tls"

# Helper to add to PATH.
# Will take current PATH so avoid running it after anything to modifies only the powershell session path.
function Add-Path ([string]$newPathItem) {
$Env:Path+= ";" + $newPathItem + ";"
[Environment]::SetEnvironmentVariable("Path",$env:Path, [System.EnvironmentVariableTarget]::Machine)
}

# Install Git for Windows
Write-Host "Installing Git for Windows."
Invoke-WebRequest -Uri https://github.com/git-for-windows/git/releases/download/v2.19.1.windows.1/Git-2.19.1-64-bit.exe -OutFile git.exe
.\git.exe /VERYSILENT /NORESTART /NOCANCEL /SP- /CLOSEAPPLICATIONS /RESTARTAPPLICATIONS /COMPONENTS="icons,ext\reg\shellhere,assoc,assoc_sh" /DIR="C:\git"
Add-Path "C:\git\bin"
Remove-Item git.exe

# Download NSSM (https://nssm.cc/) to run the BuildKite agent as a service.
Write-Host "Downloading NSSM."
Invoke-WebRequest -Uri https://nssm.cc/ci/nssm-2.24-101-g897c7ad.zip -OutFile nssm.zip
Expand-Archive -Path nssm.zip -DestinationPath C:\nssm
Add-Path "C:\nssm\nssm-2.24-101-g897c7ad\win64"
Remove-Item nssm.zip

# Run the BuildKite agent install script
Write-Host "Installing BuildKite agent."
$env:buildkiteAgentToken = $token
$env:buildkiteAgentTags = $tags
Set-ExecutionPolicy Bypass -Scope Process -Force
iex ((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/buildkite/agent/master/install.ps1'))

# Configure the BuildKite agent clone and timestamp behavior
Add-Content C:\buildkite-agent\buildkite-agent.cfg "`ngit-clone-flags=--config core.autocrlf=input --config core.eol=lf --config core.longpaths=true --config core.symlinks=true`n"
Add-Content C:\buildkite-agent\buildkite-agent.cfg "`ntimestamp-lines=true`n"

# Register the BuildKite agent service using NSSM, so that it persists through restarts and is
# restarted if the process dies.
for ($i=1; $i -le $agents; $i++)
{
$agentName = "buildkite-agent-$i"
Write-Host "Registering $agentName as a service."
nssm.exe install $agentName "C:\buildkite-agent\bin\buildkite-agent.exe" "start"
nssm.exe set $agentName AppStdout "C:\buildkite-agent\$agentName.log"
nssm.exe set $agentName AppStderr "C:\buildkite-agent\$agentName.log"
nssm.exe status $agentName
nssm.exe start $agentName
nssm.exe status $agentName
}

# Restart the machine.
Restart-Computer
19 changes: 19 additions & 0 deletions .circleci/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Encryption

Based on https://github.com/circleci/encrypted-files

In the CircleCI web UI, we have a secret variable called `KEY`
https://circleci.com/gh/angular/angular/edit#env-vars
which is only exposed to non-fork builds
(see "Pass secrets to builds from forked pull requests" under
https://circleci.com/gh/angular/angular/edit#advanced-settings)

We use this as a symmetric AES encryption key to encrypt tokens like
a GitHub token that enables publishing snapshots.

To create the github_token file, we take this approach:
- Find the angular-builds:token in http://valentine
- Go inside the CircleCI default docker image so you use the same version of openssl as we will at runtime: `docker run --rm -it circleci/node:10.12`
- echo "https://[token]:@github.com" > credentials
- openssl aes-256-cbc -e -in credentials -out .circleci/github_token -k $KEY
- If needed, base64-encode the result so you can copy-paste it out of docker: `base64 github_token`
Loading